Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning in domPdf after 7.4 upgrade #2996

Closed
jekkos opened this issue Oct 29, 2020 · 1 comment
Closed

Warning in domPdf after 7.4 upgrade #2996

jekkos opened this issue Oct 29, 2020 · 1 comment
Assignees
@jekkos
Labels
bug
Milestone
3.3.3

Comments

@jekkos
Copy link
Member

jekkos commented Oct 29, 2020 •
edited
Loading

I'm currently seeing this warning after upgrading to php 7.4 when generating PDFs

Message: Function get_magic_quotes_runtime() is deprecated

Filename: helpers/dompdf_helper.php

Line Number: 10

Backtrace:

File: /home/runwalk/domains/ospos.runwalk.be/public_html/application/helpers/dompdf_helper.php
Line: 10
Function: _error_handler

File: /home/runwalk/domains/ospos.runwalk.be/public_html/application/controllers/Sales.php
Line: 792
Function: create_pdf
@jekkos jekkos self-assigned this Oct 29, 2020
@jekkos jekkos added the bug label Oct 29, 2020
@jekkos jekkos added this to the 3.3.3 milestone Oct 29, 2020
jekkos added a commit that referenced this issue Oct 29, 2020
@jekkos
Remove magic quotes check in dompdf helper (#2996)
8a8c8b9
@jekkos
Copy link
Member Author

jekkos commented Oct 29, 2020 •
edited
Loading

This magic quote feature was already deprecated in PHP 5.3, so I'll just remove it.

jekkos added a commit that referenced this issue Oct 29, 2020
@jekkos
Remove magic quotes check in dompdf helper (#2996)
8a26195
@daN4cat daN4cat closed this as completed Oct 30, 2020
zulfiqarpk92 pushed a commit to zulfiqarpk92/opensourcepos that referenced this issue Dec 5, 2020
@jekkos @zulfiqarpk92
Remove magic quotes check in dompdf helper (opensourcepos#2996)
d6f6fac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jekkos jekkos

Labels
bug
Projects
None yet
Milestone
3.3.3
Development

No branches or pull requests
2 participants
@jekkos @daN4cat