-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 error when loading https://localhost/poss/public/index.php #3051
Comments
You are using PHP 8 so downgrade to a 7.3 or 7.4 version? |
PHP 8.0 is not supported yet. It will requires changes for sure, starting from Code Igniter. |
Solved with 7.4 Thank you |
Please leave it open because OSPOS and CI3 don't work with PHP8.0 at the moment: bcit-ci/CodeIgniter#6006 |
I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)... Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work! |
I found this on the CI4 site. |
I was still on PHP 7.2 and upgrade to PHP 7.4 and my installation is faster now. I can't imagine how faster it would get once @objecttothis improvements are merged in. |
I looked at CI4 and according to them it will mean a large rewrite of the code base. That would not be a bad time to look at other frameworks. |
Indeed, I wouldn't consider migrating to CI4 without having reconsidered the whole story here. |
I think that it would be a complete rewrite indeed, probably we could keep the database model to make it backwards compatible (or just evolve that further). |
From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html |
I had also thought that CI4 would involve quite the rewrite since he changed the way many of the functions were called. I'd say that if it's doable we should consider it, but it sounds to me like it would be quite the task. |
@jekkos I just commented on #842 regarding this but after reading the documentation on this, I don't think it would need a complete rewrite, but it does appear that there are syntax changes to the ways that different MVC elements are referenced that will touch almost every Controller, Model and View. Like I said in my comment there, I would be willing to tackle the upgrade. |
I'm assigning this to myself because I think it will be resolved by #842. |
Can we make it to support at least 8.0? It it good to have support on 8.1 too. |
This is resolved in the switch of the codebase to Code igniter 4.x. I am returning from travel in the next few weeks and will resume working on this changeover but without help it's going to be fairly slow. |
I wanted to take some time to look why the build on the branch is not working, so we can deploy it and give it a spin.. |
Glad to hear you will be back btw! |
If I get free time, I will try my best to give hand. Thanks. |
What is the status on this issue? |
It is already fixed in the next release which migrates the code to CodeIgniter 4.x. That project is still under way. You are welcome to help speed it along by helping to test or contribute code changes. |
I have Mint 21.1 / Cinnamon. Can you use that? |
Nope. I prefer Chili 5.1 and Paprika 2.0 |
@SteveIreland those are Linux distributions. Spices are nice too though 😂 |
Any OS is fine as long as you can run the appropriate AMP stack on it. |
Ok. How do i start to help? |
You'll need the code on your local branch which you can get by cloning or checking out the ci4-upgrade branch. Then you need to build the code which I believe @SteveIreland placed a build.md file in the branch showing instructions. From there you need a working Apache, MySQL (or MariaDB), PHP install. With that you should be able to start testing. You can follow the pull request at #3592 and report problems through issues. |
It looks like what I need to read to refresh my dev env to the latest and greatest. |
Yes, though I think it may be changing soon since I think @SteveIreland and @jekkos are reworking some of the old build tools in favor of gulp. |
This is encouraging!! I'm working on a consignment module atm, and will try to help test the upgrade branch when I can. Very glad this epic project is still active =) |
This is resolved in ci4-branch and will be released with 3.4.0. That version is PHP 7.4-8.2 compatible and 8.0-8.2 supported. |
when will 3.4.0 be released? |
3.4.0 is building and running. Devs need to now regression test to see what is still broken then fix those things. You can see the list of issues that need to be resolved here: https://github.com/opensourcepos/opensourcepos/milestone/17 @jekkos is it possible to have a 3.4.0 demo build for people to test then they can see the current status and report bugs to reduce the time devs need to do that. It's difficult to give a release date because it depends on devs putting time into it. I only have parts of two days that I can work on it. One dev is moving to another country and another has a separate full time job. If others want to help with contributions that will speed things up. |
I am at the airport now waiting for my flight. Should be back in harness on
Tuesday if my computers survive the trip. 😁
…On Sun, Feb 25, 2024, 5:13 PM objecttothis ***@***.***> wrote:
when will 3.4.0 be released?
3.4.0 is building and running. Devs need to now regression test to see
what is still broken then fix those things.
You can see the list of issues that need to be resolved here:
https://github.com/opensourcepos/opensourcepos/milestone/17
@jekkos <https://github.com/jekkos> is it possible to have a 3.4.0 demo
build for people to test then they can see the current status and report
bugs to reduce the time devs need to do that.
It's difficult to give a release date because it depends on devs putting
time into it. I only have parts of two days that I can work on it. One dev
is moving to another country and another has a separate full time job. If
others want to help with contributions that will speed things up.
—
Reply to this email directly, view it on GitHub
<#3051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2THY4LP2HBEIY33NMYD4TYVL6BZAVCNFSM4VFVM4CKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJWGI4DMNRSGM3A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Latest 3.4 is up at https://dev.opensourcepos.org |
@engehab87 if you want to help out, then test the instance at dev.opensourcepos.org and report back any issue encountered. Ofc check the issue list first to see if it's not a known isuse. |
is it possible that i could install it on my localhost? would help me faster to test in non internet locations. |
Yes, certainly. It is an open source application on GitHub. If you go to
https://github.com/opensourcepos/opensourcepos and follow the
installation instructions, you can run it on your local machine. I have it
on two machines including a 20 year old laptop running Linux. It works
perfectly well and allows the system to be used with no internet connection
required.
…On Thu, Feb 29, 2024, 3:16 AM ehab atef ***@***.***> wrote:
is it possible that i could install it on my localhost? would help me
faster to test in non internet locations.
—
Reply to this email directly, view it on GitHub
<#3051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2THY3HXRJJ32O437C4JZDYV4325AVCNFSM4VFVM4CKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJWHEYDONRUGAYA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
@owlbrudder thank you for your reply, but i’m asking for the 3.4.0 version |
Yes and I am running 3.4.0 on my local machines. I am a contributor to the
project, so I have to have everything local.
…On Thu, Feb 29, 2024, 7:11 AM ehab atef ***@***.***> wrote:
@owlbrudder <https://github.com/owlbrudder> thank you for your reply, but
i’m asking for the 3.4.0 version
—
Reply to this email directly, view it on GitHub
<#3051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2THY37QWR7WFAC4SDLXJTYV5XLNAVCNFSM4VFVM4CKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJWHE2TMMJWGM3A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Please write your issue here. If a bug, please make sure to provide as much information as possible including configuration settings (e.g. Decimals set, Tax mode), language, and steps to reproduce the bug.
![errors](https://user-images.githubusercontent.com/54607738/102895984-ae478e00-448b-11eb-9091-34842a46425f.PNG)
The text was updated successfully, but these errors were encountered: