Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 error when loading https://localhost/poss/public/index.php #3051

Closed
harshasuraweera opened this issue Dec 22, 2020 · 40 comments
Closed
Assignees
Milestone

Comments

@harshasuraweera
Copy link

  • PHP version is: 8.0.0

Please write your issue here. If a bug, please make sure to provide as much information as possible including configuration settings (e.g. Decimals set, Tax mode), language, and steps to reproduce the bug.
errors

@odiea
Copy link
Collaborator

odiea commented Dec 22, 2020

You are using PHP 8 so downgrade to a 7.3 or 7.4 version?

@daN4cat daN4cat changed the title I've got this error wen loading https://localhost/poss/public/index.php I've got this error when loading https://localhost/poss/public/index.php Dec 22, 2020
@daN4cat daN4cat changed the title I've got this error when loading https://localhost/poss/public/index.php PHP 8.0 error when loading https://localhost/poss/public/index.php Dec 22, 2020
@daN4cat daN4cat added the bug label Dec 22, 2020
@daN4cat daN4cat added this to the 3.4.0 milestone Dec 22, 2020
@daN4cat
Copy link
Collaborator

daN4cat commented Dec 23, 2020

PHP 8.0 is not supported yet. It will requires changes for sure, starting from Code Igniter.

@harshasuraweera
Copy link
Author

You are using PHP 8 so downgrade to a 7.3 or 7.4 version?

Solved with 7.4 Thank you

@daN4cat
Copy link
Collaborator

daN4cat commented Dec 23, 2020

Please leave it open because OSPOS and CI3 don't work with PHP8.0 at the moment: bcit-ci/CodeIgniter#6006

@daN4cat daN4cat modified the milestones: 3.4.0, 4.0.0 Dec 23, 2020
@daN4cat
Copy link
Collaborator

daN4cat commented Dec 23, 2020

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...

Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

@odiea
Copy link
Collaborator

odiea commented Dec 23, 2020

I found this on the CI4 site.
Codeigniter 4.0.4 does not support PHP 8 The community are working on update will should likely be Codeigniter 4.1 and all php8 error is getting fixed. So it looks like we should wait for 4.1 before any major changes are made.

@daN4cat
Copy link
Collaborator

daN4cat commented Jan 2, 2021

I was still on PHP 7.2 and upgrade to PHP 7.4 and my installation is faster now. I can't imagine how faster it would get once @objecttothis improvements are merged in.

@objecttothis
Copy link
Member

objecttothis commented Jan 3, 2021

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...

Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

I looked at CI4 and according to them it will mean a large rewrite of the code base. That would not be a bad time to look at other frameworks.

@daN4cat
Copy link
Collaborator

daN4cat commented Jan 3, 2021

I set version 4.0.0 because that means we need to swithc to CI4, Bootstrap 4 and who knows what else (e.g. Angular/React/View Frontend, REST API)...
Wonder if it would make sense to change framework completely to do all those changes because the upgrade to BS3 and CI3 meant a lot of work!

I looked at CI4 and according to them it will mean a large rewrite of the code base. That would not be a bad time to look at other frameworks.

Indeed, I wouldn't consider migrating to CI4 without having reconsidered the whole story here.
Maybe we should start writing down a vision about an OSPOS 4, what would be an ideal target here for a newer and better version?

@jekkos
Copy link
Member

jekkos commented Jan 3, 2021

I think that it would be a complete rewrite indeed, probably we could keep the database model to make it backwards compatible (or just evolve that further).

@jekkos jekkos removed this from the 4.0.0 milestone May 31, 2021
@jekkos
Copy link
Member

jekkos commented Jun 23, 2021

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

@objecttothis
Copy link
Member

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

I had also thought that CI4 would involve quite the rewrite since he changed the way many of the functions were called. I'd say that if it's doable we should consider it, but it sounds to me like it would be quite the task.

@objecttothis
Copy link
Member

From this conversation I thought that upgrading to CI4 would be impossible. There is however an upgrade guide and it seems to be a bit of work, but still doable

https://codeigniter4.github.io/userguide/installation/upgrade_4xx.html

@jekkos I just commented on #842 regarding this but after reading the documentation on this, I don't think it would need a complete rewrite, but it does appear that there are syntax changes to the ways that different MVC elements are referenced that will touch almost every Controller, Model and View. Like I said in my comment there, I would be willing to tackle the upgrade.

@objecttothis objecttothis self-assigned this Sep 14, 2021
@objecttothis
Copy link
Member

I'm assigning this to myself because I think it will be resolved by #842.

@objecttothis objecttothis linked a pull request Sep 14, 2021 that will close this issue
@objecttothis objecttothis added this to the 3.4.0 milestone Sep 14, 2021
@bhojkamal
Copy link
Collaborator

Can we make it to support at least 8.0? It it good to have support on 8.1 too.
Thanks.

@objecttothis
Copy link
Member

This is resolved in the switch of the codebase to Code igniter 4.x. I am returning from travel in the next few weeks and will resume working on this changeover but without help it's going to be fairly slow.

@jekkos
Copy link
Member

jekkos commented Sep 1, 2022

I wanted to take some time to look why the build on the branch is not working, so we can deploy it and give it a spin..

@jekkos
Copy link
Member

jekkos commented Sep 1, 2022

This is resolved in the switch of the codebase to Code igniter 4.x. I am returning from travel in the next few weeks and will resume working on this changeover but without help it's going to be fairly slow.

Glad to hear you will be back btw!

@bhojkamal
Copy link
Collaborator

If I get free time, I will try my best to give hand. Thanks.

@mfonhof
Copy link

mfonhof commented May 21, 2023

What is the status on this issue?

@objecttothis
Copy link
Member

It is already fixed in the next release which migrates the code to CodeIgniter 4.x. That project is still under way. You are welcome to help speed it along by helping to test or contribute code changes.

@mfonhof
Copy link

mfonhof commented May 21, 2023

I have Mint 21.1 / Cinnamon. Can you use that?

@SteveIreland
Copy link
Collaborator

Nope. I prefer Chili 5.1 and Paprika 2.0

@objecttothis
Copy link
Member

Nope. I prefer Chili 5.1 and Paprika 2.0

@SteveIreland those are Linux distributions. Spices are nice too though 😂

@objecttothis
Copy link
Member

I have Mint 21.1 / Cinnamon. Can you use that?

Any OS is fine as long as you can run the appropriate AMP stack on it.

@mfonhof
Copy link

mfonhof commented May 23, 2023

Ok. How do i start to help?

@objecttothis
Copy link
Member

You'll need the code on your local branch which you can get by cloning or checking out the ci4-upgrade branch. Then you need to build the code which I believe @SteveIreland placed a build.md file in the branch showing instructions. From there you need a working Apache, MySQL (or MariaDB), PHP install. With that you should be able to start testing. You can follow the pull request at #3592 and report problems through issues.

@daN4cat
Copy link
Collaborator

daN4cat commented Jun 6, 2023

It looks like what I need to read to refresh my dev env to the latest and greatest.

@objecttothis
Copy link
Member

It looks like what I need to read to refresh my dev env to the latest and greatest.

Yes, though I think it may be changing soon since I think @SteveIreland and @jekkos are reworking some of the old build tools in favor of gulp.

@VonHirsch
Copy link

VonHirsch commented Jun 19, 2023

This is encouraging!! I'm working on a consignment module atm, and will try to help test the upgrade branch when I can. Very glad this epic project is still active =)

@objecttothis
Copy link
Member

This is resolved in ci4-branch and will be released with 3.4.0. That version is PHP 7.4-8.2 compatible and 8.0-8.2 supported.

@engehab87
Copy link

when will 3.4.0 be released?

@objecttothis
Copy link
Member

when will 3.4.0 be released?

3.4.0 is building and running. Devs need to now regression test to see what is still broken then fix those things.

You can see the list of issues that need to be resolved here: https://github.com/opensourcepos/opensourcepos/milestone/17

@jekkos is it possible to have a 3.4.0 demo build for people to test then they can see the current status and report bugs to reduce the time devs need to do that.

It's difficult to give a release date because it depends on devs putting time into it. I only have parts of two days that I can work on it. One dev is moving to another country and another has a separate full time job. If others want to help with contributions that will speed things up.

@owlbrudder
Copy link
Collaborator

owlbrudder commented Feb 25, 2024 via email

@jekkos
Copy link
Member

jekkos commented Feb 28, 2024

Latest 3.4 is up at https://dev.opensourcepos.org

@jekkos
Copy link
Member

jekkos commented Feb 28, 2024

@engehab87 if you want to help out, then test the instance at dev.opensourcepos.org and report back any issue encountered. Ofc check the issue list first to see if it's not a known isuse.

@engehab87
Copy link

is it possible that i could install it on my localhost? would help me faster to test in non internet locations.

@owlbrudder
Copy link
Collaborator

owlbrudder commented Feb 28, 2024 via email

@engehab87
Copy link

@owlbrudder thank you for your reply, but i’m asking for the 3.4.0 version

@owlbrudder
Copy link
Collaborator

owlbrudder commented Feb 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.