/os-conductor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'/packager/update_params' endpoint #31

Merged
merged 6 commits into from Apr 13, 2018

Conversation

Reviewers

@vitorbaptista vitorbaptista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brew @vitorbaptista
@brew
Member

brew commented Apr 12, 2018

Update defaultParams property for a package entry managed by os-package-registry (elasticsearch).

  • Check owner of the package is same as user in the jwt
  • Update package model 'defaultParams' property with the passed json in the request body.
  • Clear the os-api cache for the package.

Part of openspending/openspending#1187
@brew
New '/packager/update_params' endpoint 
Update a package model 'defaultParams' property with the passed request
json. Clears the os-api cache for the package.
Loading status checks…
3f35658

@brew brew added the in progress label Apr 12, 2018

@brew brew referenced this pull request Apr 12, 2018

Merged

Save default view parameters #179

@brew brew requested a review from vitorbaptista Apr 12, 2018

@vitorbaptista

vitorbaptista approved these changes Apr 12, 2018
View changes

Everything looks good, just missing some tests 👍

Show outdated Hide outdated conductor/blueprints/package/controllers.py

@brew brew merged commit 6310fef into master Apr 13, 2018
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.6%) to 74.599%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brew brew removed the in progress label Apr 13, 2018

@brew brew deleted the 1187/default-view branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment