Save default view parameters #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only use defaultParams if there are no visualizations defined. This allows users to setup their own params and share the resultant url.
Adds controls for dataset owner to save current view as default. Add user controls to reset the entire view, or reset the view to the default parameters. - Adds a `param-controls` directive to manage the UI and controller code for the default params. - View params are saved via the data-package-api to the package model in the ElasticSearch instance. This is mediated by os-conductor by the new `/package/update_params` endpoint. - `confirmation-popover` directive added to UI for the 'Save View As Default' action, which is only shown to the dataset owner.
vitorbaptista
approved these changes
Apr 12, 2018
Because Elasticsearch update merges object values with existing values, we need a way to replace the params entirely. We don't have access to Elasticsearch scripting, so the easiest way is to dump the params object to a string, and send it as a value of a 'params' key. The stringified json object is parsed back to an object before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows dataset owners to set up and save a default view for their packages. It uses a new
/package/update_paramsos-conductor endpoint to save current view parameters to the package model (openspending/os-conductor#31).Best to review both this and the related os-conductor PR together. These changes are currently live on the staging server: https://staging.openspending.org/.
Closes of openspending/openspending#1187