Support authorization in datastore #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also take into account the owner when creating the urls.
| return True | ||
| return False | ||
| global public_key |
There was a problem hiding this comment.
I wanted to have a singleton pattern here, so that we load the public_key only once and lazily (i.e. only on first request). How would you do it?
There was a problem hiding this comment.
I'd just load it with the module. But global is fine.
There was a problem hiding this comment.
OK - the reason I didn't go that way was to avoid a network request upon importing the module.
|
@akariv I'm done. Some comments to address before merge. Most are trivial points, but I think you should at least create an issue for the refactor of the class pattern. |
akariv
force-pushed
the
feature/datastore-authorization
branch
from
18d4d28
to
46e37a0
Compare
|
@pwalsh - I fixed some of the issues and created #7 |
|
@akariv great. looks good. ok to merge. |
akariv
added a commit
that referenced
this pull request
Feb 16, 2016
Support authorization in datastore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the way the datastore authenticates requests.
It used to be with API keys, now it's with a cryptographic token.
Some other changes here: