-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save default view parameters #179
Merged
Merged
Commits on Apr 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 06ea74a - Browse repository at this point
Copy the full SHA 06ea74aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1a8a22 - Browse repository at this point
Copy the full SHA a1a8a22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3684fcf - Browse repository at this point
Copy the full SHA 3684fcfView commit details
Commits on Apr 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 084e80c - Browse repository at this point
Copy the full SHA 084e80cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d96569b - Browse repository at this point
Copy the full SHA d96569bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c814d22 - Browse repository at this point
Copy the full SHA c814d22View commit details
Commits on Apr 9, 2018
-
Don't use defaultParams if visualizations defined in query string
Only use defaultParams if there are no visualizations defined. This allows users to setup their own params and share the resultant url.
Configuration menu - View commit details
-
Copy full SHA for 9570b47 - Browse repository at this point
Copy the full SHA 9570b47View commit details
Commits on Apr 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7b60bd8 - Browse repository at this point
Copy the full SHA 7b60bd8View commit details -
Default paramater controls for views
Adds controls for dataset owner to save current view as default. Add user controls to reset the entire view, or reset the view to the default parameters. - Adds a `param-controls` directive to manage the UI and controller code for the default params. - View params are saved via the data-package-api to the package model in the ElasticSearch instance. This is mediated by os-conductor by the new `/package/update_params` endpoint. - `confirmation-popover` directive added to UI for the 'Save View As Default' action, which is only shown to the dataset owner.
Configuration menu - View commit details
-
Copy full SHA for f4c1e12 - Browse repository at this point
Copy the full SHA f4c1e12View commit details
Commits on Apr 13, 2018
-
Because Elasticsearch update merges object values with existing values, we need a way to replace the params entirely. We don't have access to Elasticsearch scripting, so the easiest way is to dump the params object to a string, and send it as a value of a 'params' key. The stringified json object is parsed back to an object before use.
Configuration menu - View commit details
-
Copy full SHA for e348f92 - Browse repository at this point
Copy the full SHA e348f92View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1b9c1a - Browse repository at this point
Copy the full SHA e1b9c1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e930cf5 - Browse repository at this point
Copy the full SHA e930cf5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.