Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save default view parameters #179

Merged
merged 12 commits into from
Apr 13, 2018
Merged

Save default view parameters #179

merged 12 commits into from
Apr 13, 2018

Commits on Apr 5, 2018

  1. Fix variable typo

    brew committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    06ea74a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a1a8a22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3684fcf View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    084e80c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d96569b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c814d22 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2018

  1. Don't use defaultParams if visualizations defined in query string

    Only use defaultParams if there are no visualizations defined. This
    allows users to setup their own params and share the resultant url.
    brew committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    9570b47 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Configuration menu
    Copy the full SHA
    7b60bd8 View commit details
    Browse the repository at this point in the history
  2. Default paramater controls for views

    Adds controls for dataset owner to save current view as default. Add
    user controls to reset the entire view, or reset the view to the default
    parameters.
    
    - Adds a `param-controls` directive to manage the UI and controller code
    for the default params.
    - View params are saved via the data-package-api to the package model in
    the ElasticSearch instance. This is mediated by os-conductor by the new
    `/package/update_params` endpoint.
    - `confirmation-popover` directive added to UI for the 'Save View As
    Default' action, which is only shown to the dataset owner.
    brew committed Apr 12, 2018
    Configuration menu
    Copy the full SHA
    f4c1e12 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2018

  1. Send param as string value.

    Because Elasticsearch update merges object values with existing values,
    we need a way to replace the params entirely. We don't have access to
    Elasticsearch scripting, so the easiest way is to dump the params object
    to a string, and send it as a value of a 'params' key. The stringified
    json object is parsed back to an object before use.
    brew committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    e348f92 View commit details
    Browse the repository at this point in the history
  2. Lower case 'as'

    brew committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    e1b9c1a View commit details
    Browse the repository at this point in the history
  3. Fix tests

    brew committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    e930cf5 View commit details
    Browse the repository at this point in the history