Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to approve entitlements of a cycle that is still not approved #538

Closed
anthonymarkQA opened this issue Aug 20, 2024 · 1 comment · Fixed by #541
Closed

Able to approve entitlements of a cycle that is still not approved #538

anthonymarkQA opened this issue Aug 20, 2024 · 1 comment · Fixed by #541
Assignees
Labels
bug Something isn't working

Comments

@anthonymarkQA
Copy link

anthonymarkQA commented Aug 20, 2024

Describe the bug
I am able to approve the entitlements within a cycle even though the cycle is still not approved.
(Kindly review this ticket carefully if it is indeed an issue or not.)
To Reproduce

  1. Go to SP-MIS QA and login as QA
  2. Click on programs, then select an existing program named "test2"
  3. create a new cycle under that program
  4. click "prepare entitlements"
  5. Instead of clicking "to approve" button, click entitlements tab.
  6. highlight the entitlements by ticking the checkboxes
  7. click on action button then select approve.
  8. A modal should appear. click approve.
  9. Notice that i am able to approve the entitlements even if the cycle is not approved yet.

Expected behavior

  1. Should only be able to approve entitlements if cycle is already approved.
  2. Should be applied to OpenSPP that uses program modules.
  3. NOTE: if auto approve entitlements is enabled, approving a cycle should automatically set its entitlements to approved if possible.(if funds are enough etc..)

Screenshots

Image

Additional context

🔔 Note: This ticket should address common considerations without including country-specific content. Please ensure all references are generic and applicable across various contexts.

@anthonymarkQA anthonymarkQA added the bug Something isn't working label Aug 20, 2024
@anthonymarkQA anthonymarkQA changed the title Able to approve entitlements of cycle that is still not approved Able to approve entitlements of a cycle that is still not approved Aug 20, 2024
@reichie020212 reichie020212 self-assigned this Aug 21, 2024
@reichie020212 reichie020212 linked a pull request Aug 21, 2024 that will close this issue
@jannahadlaon
Copy link

Works as expected
Tested in: https://qa-sp-mis.newlogic.net/
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants