-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack QuestionnaireResponse repeatedGroup items before validation #3267
Conversation
before validation borrows from sdk: google/android-fhir#1936
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3267 +/- ##
=========================================
- Coverage 29.6% 28.2% -1.4%
- Complexity 658 719 +61
=========================================
Files 239 265 +26
Lines 11204 12706 +1502
Branches 1948 2259 +311
=========================================
+ Hits 3323 3595 +272
- Misses 7447 8642 +1195
- Partials 434 469 +35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f2e0c13
to
6c80977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LZRS I saw this SDK PR google/android-fhir#2564 that has changes to fix packing for nested questions.
Do we still need this PR (with your changes) in FHIRCore?
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #3245
Similar implementation to: google/android-fhir#1936
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file