Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack QuestionnaireResponse repeatedGroup items before validation #3267

Merged
merged 17 commits into from
Jun 21, 2024

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented May 15, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3245
Similar implementation to: google/android-fhir#1936

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (ac82739) to head (a8bc9a1).
Report is 100 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3267     +/-   ##
=========================================
- Coverage     29.6%   28.2%   -1.4%     
- Complexity     658     719     +61     
=========================================
  Files          239     265     +26     
  Lines        11204   12706   +1502     
  Branches      1948    2259    +311     
=========================================
+ Hits          3323    3595    +272     
- Misses        7447    8642   +1195     
- Partials       434     469     +35     
Flag Coverage Δ
engine 64.9% <100.0%> (-1.3%) ⬇️
geowidget 18.3% <ø> (-28.9%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/util/extension/QuestionnaireResponseExtension.kt 100.0% <100.0%> (ø)
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 2.8% <0.0%> (-0.8%) ⬇️

... and 25 files with indirect coverage changes

@LZRS LZRS marked this pull request as ready for review May 15, 2024 07:19
pld
pld previously approved these changes Jun 11, 2024
@pld pld enabled auto-merge (squash) June 11, 2024 15:01
pld
pld previously approved these changes Jun 12, 2024
@LZRS LZRS force-pushed the 3245-pack-repeated-group-validation branch from f2e0c13 to 6c80977 Compare June 20, 2024 07:49
Copy link
Contributor

@allan-on allan-on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LZRS I saw this SDK PR google/android-fhir#2564 that has changes to fix packing for nested questions.

Do we still need this PR (with your changes) in FHIRCore?

@pld pld merged commit e8065c9 into main Jun 21, 2024
5 checks passed
@pld pld deleted the 3245-pack-repeated-group-validation branch June 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving a questionnaire with nested repeatedGroup items fails with crash
4 participants