Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack repeated groups even if there is only one group in the response #2564

Merged
merged 9 commits into from
Jun 7, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Jun 6, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
The current logic to pack repeated groups does not actually look at the questionnaire item at all. It simply packs multiple groups of the same id and assume they are from the same repeated group. This is fine unless if there is only one repeated group answer, the logic won't be able to distinguish this from non-repeated group.

The fix adds the questionnaire item to the logic so it packs if and only if it's a repeated group.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@jingtang10 jingtang10 linked an issue Jun 6, 2024 that may be closed by this pull request
@jingtang10 jingtang10 marked this pull request as ready for review June 6, 2024 16:37
@jingtang10
Copy link
Collaborator Author

thanks for the review aditya - addressed comments

@jingtang10 jingtang10 enabled auto-merge (squash) June 7, 2024 17:31
@jingtang10 jingtang10 disabled auto-merge June 7, 2024 17:31
@jingtang10 jingtang10 enabled auto-merge (squash) June 7, 2024 18:48
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingtang10 jingtang10 merged commit df463c7 into google:master Jun 7, 2024
4 checks passed
@jingtang10 jingtang10 deleted the repeated-group branch June 17, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Handle repeated groups
3 participants