-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new UI elements to ZEIR app #474
Comments
I can work on |
Add a sync status snacbar in the activity drawer Part fo fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
Use a BroadcastReceiver to tell BaseActivity and BaseRegisterActivity if sync is currently running Part of fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
Unregister the SyncStatus BroadcastReceiver in BaseActivity and BaseRegisterActivity when the activity is destroyed Part of fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
Add a global instance of SyncStatusBroadcastReceiver for easier subscibing and unsubscribing by BaseActivity and BaseRegisterActivity Part of fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
@cagulas The sync button reflects when the sync started |
@jasonrogena @rowo OK, Let's change it to when the last sync was successfully completed. Right now, it's confusing, because the sync could be failing, but according to the side menu, it appears the syncing is working, as it shows the last sync time. So, if the sync fails, it should continue to show the last successful sync time, if the sync is successful, it should update to the current time. |
Add a loading spinner when syncing in the ChildSmartRegisterFragment Part of fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
Make the list of siblings scroll horizontally, instead of expanding vertically Part of fix for issue #474 Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
@jasonrogena putting the last item in a new issue, since it won't be complete for this release: #504 |
@jasonrogena When I turn off my wifi on my tablet, then press sync, I see the "Sync complete" snackbar message. It shouldn't show this, since there was no internet connection. I think it should show a message that sync cannot happen, because there is no internet connection. So maybe a snackbar message that says "Sync failed. Check your internet connection." Or something similar to that. What do you think? |
@cagulas "Sync failed. Check your internet connection." makes a lot of sense |
@jasonrogena I'm moving the last part about showing sync failed if offline to a new issue (#527), so we can close this one. |
Added sync failed due to error as a new issue: #528. Closing this issue now. |
CG: This can be the status immediately shown when vaccines are recorded, and then it can be updated to the next vaccine due date status when it syncs with the scheduling engine. Please note, however, that if not all the vaccines are given (e.g., only BCG is given, but OPV 0 was not), the status should remain the same due status for the birth vaccines. In future, we can see about changing the status to only show which vaccine was not given, but for now, I think it's ok to just continue to show due at birth.
Important notes: You should also be able to get to the child status modal (above) by clicking on the child's current displayed status in the detailed view (the icon next to their name and image). Clicking outside of the menu closes it without changes. Clicking the same option closes the menu without changes. Clicking on another option updates the status and closes the window.
Icon: https://material.io/icons/#ic_more_vert
After sync is clicked, we need some sort of indication that (1) the sync button was clicked and (2) it is currently syncing. A snackbar at the bottom would be nice. So after you click "Sync" in the menu:
Tips on snackbar interaction from [Material guidelines](https://material.io/guidelines/components/snackbars-toasts.html#):
The text was updated successfully, but these errors were encountered: