Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues to resolve after April 28th release (to be complete for V1.1.3) #486

Closed
26 of 29 tasks
geoffreymuchai opened this issue Apr 24, 2017 · 1 comment
Closed
26 of 29 tasks

Comments

@geoffreymuchai
Copy link

geoffreymuchai commented Apr 24, 2017

These are listed in order of priority to work on:

Schedules

  • From issue 31st march release Initial Feedback #470: Recording one vaccine out of a number of vaccines that are due de-activates the overdue or due status. Eg. if four vaccines were due and one was not given, the status should remain due or overdue.
    CG: I have been able to observe this with child Mary Mwelwa (ID: 1038504). I gave all 6 weeks vaccines, except for Rota 1. On the home screen, it showed due 10 weeks when it should still show due 6 weeks since Rota 1 was not given.

Edit birth registration form

  • If you take a new picture of the child, it should replace the existing one, but currently it doesn't
  • For required fields, if you try to save, it should automatically scroll to the part in the form that is required before submission, but currently, when you select "Save", it doesn't scroll and appears as if nothing happens.

Location hierarchies

  • Need to truncate all locations in the hierarchy that have a "so" prefix. This comes from the DHIS2 locations, where "so" means Southern Province. We don't need this, so remove "so" from the province name, district names, and health facility names (zones and residential areas do not have this, since we added these levels ourselves)

Advanced search

  • The advanced search page keeps your search parameters when you leave the advanced search page. This shouldn't happen. For instance, previously, I did a search for a child named "Julius". Later, when I scanned a QR code for another child, I selected the "search out of catchment records" option, and when it opened the page, it pre-populated the ZEIR ID from the QR code, but for some reason, it still had "Julius" showing in the first name field. It seems that the advanced search parameters are not clearing between searches.
  • Advanced search page UI fixes (see below)
    as
  • UI fixes to the results page (see below)
    asr
  • In the screenshot immediately above, the results are not being filtered by active and inactive or lost to followup. In the search terms, you can see I searched for "active" kids only, yet an inactive kid was returned in the results.
  • Not all of the child's data is appearing after "move to my catchment" action. See screenshot below. I moved this kid from Linda to Vic Falls clinic. A lot of the data is not appearing in the detailed view, including mother guardian name, etc.
    screenshot_20170411-125832
  • In the screenshot above, the locations that transferred over are appearing with their unique ID instead of the location name. Although, when I transferred another child over (Kaylaa Smithh) after this, the location name appears instead of the ID.
  • See screenshot below. When you move a kid to a new catchment area, the child's Home_Facility should change to that of the new clinic. In the screenshot below, Kaylaa was transferred from Linda to Vic Falls, but her home clinic is still appearing as Linda.
    screenshot_20170411-131728
  • If you move a kid to a new catchment area, they should unsync from the tablet of the previous catchment area. For example, I moved two kids from Linda to Vic Falls (Kaylaa Smithh and Smith), so they should now only appear when logged in as a user from Vic Falls. Right now, they are still appearing when I log in as a Linda user.
  • After you do "move to my catchment", the kid doesn't appear immediately in the home screen after the record syncs. Can this happen quicker? I had to sync and re-visit the home screen a few times for the newly synced record to appear.
  • The confirm form close message is different in the forms compared to the advanced search screen (the Yes, No buttons are swapped). They should be the same throughout the app, so I would replace the one on the advanced search page to match the ones in the forms.

Detailed view
Assigning this entire section to @raihan-mpower to start working on.

  • Edits for weight and vaccine data should be allowed for a period of 3 months after data is first recorded. Birth registration can always be edited and has no date limit.
  • The "Save" button on the top right of the detailed view screen should match the font, format, spacing, etc. of the "SAVE" form in the birth registration form.
  • When editing weights, the edit button only ever appears next to one weight; it should appear next to all weights (except birth weight, i.e., the weight for 0d).
  • Upon selecting the edit weight option in the detailed view, the menu floats to the left before disappearing (sent email with the video, since I'm unable to attach here)
    CG: Won't fix, as it's not reproducible on other tablets.
  • If a vaccine expires, it should show as expired on the Under Five History tab as well. For e.g., see child Beth Drew, ID: 1021005. Her OPV 0 is expired, so on the Under Five History tab, it would be nice if this showed as expired too.

Other issues

  • Mother/guardian DOB is showing as "31-12-1959" in the detailed view when the field was left blank in the form. This should remain blank in the detailed view. It should only show a DOB if the user then edits the birth registration form and adds a DOB for the mother. Currently, if you open the birth registration form to edit, it shows the default DOB in the registration form, and the user cannot even edit it.
  • The mother's default DOB should be 01-01-1960, not 31-12-1959.
  • Inactive and Lost to Followup icons are spaced too far from their text on the home screen. See mockups.
  • If a child is inactive or lost to followup, the "Record weight" button should not be shown on the home screen (see mockups)
  • Required message alerts are not all aligned in the birth registration form (issue carried over from Fix known issues from ZEIR March 31st release and add missing features #446 issue)
  • The "Record weight" button should reset 12 hours after a weight is recorded.
  • Add siblings in the vaccine card view for those kids that share the same mother_id i.e select c.* from ec_child c inner join ec_mother m on m.base_entity_id=c.relational_id where c.relational_id='{current_child_id}'
  • Think there was misunderstanding in showing the green check mark on the home screen after vaccines were given. The green check should show the vaccines that were just given, not the ones that are due next. For instance, if birth vaccines were just given, it should show a green check and say "Birth". Right now, when you record birth vaccines, it shows a green check and 6 weeks.

Report adverse event

  • For some reason, when you open the Report Adverse Event form, it launches the date widget first. This isn't the first field in the form, so it shouldn't appear first.
  • The name of the form should be "Report adverse event". Right now, it is showing as "Record an adverse event"
@cafootitt cafootitt changed the title Issues to resolve after May 2nd Release Issues to resolve after April 28th release Apr 24, 2017
@cafootitt cafootitt added this to the BID Zambia May Release milestone Apr 25, 2017
keymane pushed a commit that referenced this issue May 3, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
jasonrogena added a commit that referenced this issue May 5, 2017
Fix issue causing the native forms not to scroll to the first error
message in a form when save is clicked

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
jasonrogena added a commit that referenced this issue May 5, 2017
Change the heading for the adverse event form

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
keymane pushed a commit that referenced this issue May 5, 2017
…chment #486

Signed-off-by: Ephraim Muhia <emuhia@ona.io>
keymane pushed a commit that referenced this issue May 8, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
keymane pushed a commit that referenced this issue May 9, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
jasonrogena added a commit that referenced this issue May 9, 2017
Change how spinners in native forms are created so as to prevent them
from having a different error message padding with other widgets

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
jasonrogena added a commit that referenced this issue May 9, 2017
Add logic for editing a child's profile picture from the Birth
Registration form

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
keymane pushed a commit that referenced this issue May 9, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
keymane pushed a commit that referenced this issue May 11, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
jasonrogena added a commit that referenced this issue May 11, 2017
Add logic for showing sibling profile pictures in the
ChildImmunizationActivity

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
jasonrogena added a commit that referenced this issue May 12, 2017
Add logic for fetching sibling data from the database in
ChildImmunizationActivity

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
jasonrogena added a commit that referenced this issue May 12, 2017
Execute AsyncTasks for fetching sibling data in the shared Thread Pool

Part of fix for issue #486

Signed-off-by: Jason Rogena <jasonrogena@gmail.com>
keymane pushed a commit that referenced this issue May 12, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
@cafootitt cafootitt changed the title Issues to resolve after April 28th release Issues to resolve after April 28th release (to be complete for V1.1.3) May 18, 2017
keymane pushed a commit that referenced this issue May 18, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
keymane pushed a commit that referenced this issue May 19, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
keymane pushed a commit that referenced this issue May 24, 2017
Signed-off-by: Ephraim Muhia <emuhia@ona.io>
@cafootitt
Copy link

Closing this issue. All remaining work and bugs identified during QA are moved to new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants