95-test_external_pyca_data/cryptography.py: only install for testing

[levitte]

Also, be less silent when installing, so possible errors are shown.

[extended tests]

Fixes #3005

[alex]

Which of the builder's output should I look at?

[levitte]

Hold on, I just condensed .travis.yml to only contain builds that would only exercise test_external_pyca

[levitte]

So from now on, it's any build you can see...

[alex]

I think you may have excluded too much, in the output I see "ok 1 # skip PYCA Cryptography not available"

[levitte]

Yeah, I noticed. I'm not sure what caused this, but I keep experimenting. I see further up in the log that the pyca-cryptography submodule is checked out, so pyca-cryptography/setup.py should be there...

[levitte]

Finally got it right...

[alex]

Ok, we now have a clear error message: https://travis-ci.org/openssl/openssl/builds/213413215#L808-L818

If you don't want to install all our weird dependencies for a full dev environment you can reply pip install -r dev-requirements.txt with pip install .[test], that should get everything you need just to run the tests.

[levitte]

Right now, I'm trying the other way around, to install libenchant-dev to see if that solves the issue. But if only pip-installing the test requirements is enough, I'm game as well!

[levitte]

I think I'll opt for simplicity, so pip install .[test] it is.

Time to make a nice patch of this PR and take it out of WIP.

[alex]

👍

[levitte]

Done. Review time.

[levitte]

.travis.yml is restore. In the current build, the xxxx.9 job is the one to look at.

[levitte]

Sorry, wrong, I meant the xxxx.7 job.

[levitte]

It seems I'm getting another type of error now:

Traceback (most recent call last):
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/_pytest/config.py", line 362, in _importconftest
    mod = conftestpath.pyimport()
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/py/_path/local.py", line 662, in pyimport
    __import__(modname)
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/_pytest/assertion/rewrite.py", line 216, in load_module
    py.builtin.exec_(co, mod.__dict__)
  File "/home/travis/build/openssl/openssl/venv-pycrypto/local/lib/python2.7/site-packages/py/_builtin.py", line 221, in exec_
    exec2(obj, globals, locals)
  File "<string>", line 7, in exec2
  File "/home/travis/build/openssl/openssl/pyca-cryptography/tests/conftest.py", line 10, in <module>
    from cryptography.hazmat.backends.openssl import backend as openssl_backend
  File "/home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/backends/openssl/__init__.py", line 7, in <module>
    from cryptography.hazmat.backends.openssl.backend import backend
  File "/home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/backends/openssl/backend.py", line 49, in <module>
    from cryptography.hazmat.bindings._openssl import lib as _lib
ImportError: /home/travis/build/openssl/openssl/pyca-cryptography/src/cryptography/hazmat/bindings/_openssl.so: undefined symbol: __gcov_merge_add
ERROR: could not load /home/travis/build/openssl/openssl/pyca-cryptography/tests/conftest.py

That particular job is configured no-shared... @alex, that would never work with the pyca tests, would it? It seems we need to make a separate job for external tests...

[alex]

It's definitely possibly to statically link a .a with pyca/cryptography, though I can't remember how off hand. /cc @reaperhulk

[levitte]

I find this reason enough to have a separate job for external tests...

[levitte]

Ok, it builds!

[levitte]

Merged. 8c1054a to 34fffdb