-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
95-test_external_pyca_data/cryptography.py: only install for testing #3007
Conversation
Which of the builder's output should I look at? |
Hold on, I just condensed |
So from now on, it's any build you can see... |
I think you may have excluded too much, in the output I see "ok 1 # skip PYCA Cryptography not available" |
Yeah, I noticed. I'm not sure what caused this, but I keep experimenting. I see further up in the log that the pyca-cryptography submodule is checked out, so |
f6fcd40
to
71e78c8
Compare
Finally got it right... |
Ok, we now have a clear error message: https://travis-ci.org/openssl/openssl/builds/213413215#L808-L818 If you don't want to install all our weird dependencies for a full dev environment you can reply |
b7ed433
to
38dda4d
Compare
Right now, I'm trying the other way around, to install libenchant-dev to see if that solves the issue. But if only pip-installing the test requirements is enough, I'm game as well! |
I think I'll opt for simplicity, so Time to make a nice patch of this PR and take it out of WIP. |
👍 |
Also, be less silent when installing, so possible errors are shown. [extended tests] Fixes openssl#3005
7f20bc9
to
cde036c
Compare
Done. Review time. |
|
Sorry, wrong, I meant the xxxx.7 job. |
It seems I'm getting another type of error now:
That particular job is configured |
It's definitely possibly to statically link a |
Some of the external tests do not run well with 'no-shared'
[extended tests]
I find this reason enough to have a separate job for external tests... |
Ok, it builds! |
Some of the external tests do not run well with 'no-shared' Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #3007)
[extended tests] Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #3007)
Also, be less silent when installing, so possible errors are shown.
[extended tests]
Fixes #3005