Add BaseWallabyOVNChassisCharm class #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openstack-release package is added in the Wallaby class as this package was introduced in the wallaby release to make determination of the OpenStack release codename easier. Closes-Bug: #1951462
ajkavanagh
reviewed
Nov 19, 2021
lib/charms/ovn_charm.py
Outdated
Comment on lines
948
to
961
| class BaseWallabyOVNChassisCharm(BaseOVNChassisCharm): | ||
| """Wallaby incarnation of the OVN Chassis base charm class.""" | ||
| abstract_class = True | ||
| openstack_packages = ['neutron-ovn-metadata-agent', 'openstack-release'] | ||
| openstack_services = ['neutron-ovn-metadata-agent'] | ||
| openstack_restart_map = { | ||
| '/etc/neutron/neutron_ovn_metadata_agent.ini': [ | ||
| 'neutron-ovn-metadata-agent']} | ||
| nrpe_check_base_services = [ | ||
| 'ovn-controller', | ||
| 'ovs-vswitchd', | ||
| 'ovsdb-server'] | ||
| nrpe_check_openstack_services = [ | ||
| 'neutron-ovn-metadata-agent'] |
There was a problem hiding this comment.
This is practically the same as the Ussuri one. Why not do:
class BaseWallabyOVNChassisCharm(BaseUssuriOVNChassisCharm):
abstract_class = True
openstack_packages = ['neutron-ovn-metadata-agent', 'openstack-release']There was a problem hiding this comment.
I wanted to do that but decided to follow suit. I'll update that.
ajkavanagh
suggested changes
Nov 19, 2021
lourot
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openstack-release package is added in the Wallaby class as this
package was introduced in the wallaby release to make determination
of the OpenStack release codename easier.
Closes-Bug: #1951462