Skip to content

Commit

Permalink
Big Switch: Don't clear hash before sync
Browse files Browse the repository at this point in the history
This patch removes the step of clearing the consistency
hash from the DB before a topology sync. This will ensure
that inconsistency will be detected if the topology sync
fails.

This logic was originally there to make sure the hash header
was not present on the topology sync call to the backend.
However, the hash header is ignored by the backend in a sync
call so it wasn't necessary.

Closes-Bug: #1379510
Change-Id: I2d58fa2aea3b692834d64192d06ace727c7df8a0
  • Loading branch information
kevinbenton committed Oct 7, 2014
1 parent 9737424 commit 24e4110
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions neutron/plugins/bigswitch/servermanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,6 @@ def rest_call(self, action, resource, data, headers, ignore_codes,
if not self.get_topo_function:
raise cfg.Error(_('Server requires synchronization, '
'but no topology function was defined.'))
# The hash was incorrect so it needs to be removed
hash_handler.put_hash('')
data = self.get_topo_function(**self.get_topo_function_args)
active_server.rest_call('PUT', TOPOLOGY_PATH, data,
timeout=None)
Expand Down

0 comments on commit 24e4110

Please sign in to comment.