Link preview for figure in another module #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t only content links get processed, as opposed to footer links as well, clean up prop names
pandafulmanda
changed the title
2 tasks
pandafulmanda
force-pushed
the
feature/link-preview-async
branch
from
6e5eba6
to
35b0690
Compare
pandafulmanda
force-pushed
the
feature/link-preview-async
branch
from
decaf53
to
eb2c2f8
Compare
|
closing in favor of combo PR #767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #725, helps address #758
preview for figure in another module/page/whatever
in both iReading and Ref Book
Does not link externally in iReading
Does link externally in reference book view
Even makes the moving man in an interactive step
look cooler
With image loading state