Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automatically set machine state to error upon disconnect of writer #1054

Closed
wants to merge 2 commits into from
Closed

automatically set machine state to error upon disconnect of writer #1054

wants to merge 2 commits into from

Commits on Dec 16, 2020

  1. automatically set machine state to error upon disconnect of writer 

    Most of the implementations of the run method of the ThreadedStenotypeBase
do not catch exceptions. This causes the thread to silently die (the
exception is only logged to the console).

Now an exception in the run method is reported as an error to the system
and additionally the SerialStenotypeBase class does close the com port on
error.

Otherwise the com port resource might still be taken by plover upon
reconnect of the writer, and a different com port might be taken by the OS
and plover might not be able to reconnect to that machine.

This is a first part to solving issue openstenoproject#596. In addition there must be some
mechanism to retry connecting when the state is error.
    @tschulte @pianohacker
    tschulte authored and pianohacker committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ee8f875 View commit details
    Browse the repository at this point in the history

  2. Suggested edits from @morinted

    @pianohacker
    pianohacker committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c4b8956 View commit details
    Browse the repository at this point in the history