Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't include empty comment #1360

Closed
goldfndr opened this issue Apr 21, 2013 · 1 comment
Closed

Don't include empty comment #1360

goldfndr opened this issue Apr 21, 2013 · 1 comment
Assignees
@jfirebaugh

Comments

@goldfndr
Copy link

The web pages for http://www.openstreetmap.org/browse/node/2274578265 and http://www.openstreetmap.org/browse/way/218189993 look odd (misformatted?) in Google Chrome and Windows Internet Explorer 8: their Tags field seems to be part of the Comment field. Examining each one's Changeset XML shows that the line

<tag k="comment" v=""/>

was part of them. Other Changeset XMLs omit this line if the comment is empty.
@tmcw
Copy link
Contributor

tmcw commented Apr 21, 2013

This is really a half-and-half bug - iD shouldn't a comment tag if there isn't one, but osm.org also should format this correctly.

@ghost ghost assigned jfirebaugh Apr 22, 2013
jfirebaugh added a commit to jfirebaugh/openstreetmap-website that referenced this issue Apr 22, 2013
@jfirebaugh
Don't display empty changeset comments
32959ae 
See openstreetmap/iD#1360. We will also change iD to omit empty comments.
@jfirebaugh jfirebaugh mentioned this issue Apr 22, 2013
Closed
@goldfndr goldfndr mentioned this issue May 19, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfirebaugh jfirebaugh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmcw @jfirebaugh @goldfndr