Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the wrong feature gets selected #1693

Closed
tyrasd opened this issue Aug 16, 2013 · 9 comments
Closed

Sometimes the wrong feature gets selected #1693

tyrasd opened this issue Aug 16, 2013 · 9 comments
Labels
bug A bug - let's fix this!

Comments

@tyrasd
Copy link
Member

tyrasd commented Aug 16, 2013

Sometimes when clicking on, say the area of a building, iD selects a (large) background landuse polygon instead. To select the actual building one has to click on its outline. The building does show the hover-highlight only when hovering over its outline, not its inside. This happens not with all buildings inside the same landuse polygon, but can happen with both multipolygons and regular closed ways. After some panning around this bug usually disappears, but may reappear somewhere else.

To reproduce, take a look at this example location and try to select the multipolygon building in the centre or the building directly North of that.
http://openstreetmap.us/iD/release/#background=Bing&map=19.00/11.24400/46.41283

Tested in FF20 and Chrome23.

Could this be related to #1676?

@jfirebaugh
Copy link
Member

Regressed in 1db9958.

@jfirebaugh
Copy link
Member

This is difficult to fix. 1db9958 was an important optimization, but somehow all the SVG paths still need to be inserted in order of descending area.

@Stalfur
Copy link
Contributor

Stalfur commented Aug 17, 2013

Encountered same, seems harder to edit in current version than before (for those of us with powerful desktops)

@tyrasd
Copy link
Member Author

tyrasd commented Aug 19, 2013

Here is an example of a newby mistake very likely triggered by this bug: The user obviously wanted to select a building to mark it as a restaurant. Instead, he ended up selecting the background landuse multipolygon. And now we have an awkward kilometre long building. :(

@tyrasd
Copy link
Member Author

tyrasd commented Aug 19, 2013

This issue could at least be attenuated by implementing #1702 solving #542.

@jfirebaugh
Copy link
Member

Yeah, I agree that error was probably caused by this bug -- we'll find some way to fix it.

Not sure that something like #1702 would help in this case. The area in question falls on the border of the landuse polygon so it would probably be visible.

@lsces
Copy link

lsces commented Aug 25, 2013

Working in areas where a large number of areas overlap one another, there is a definite disadvantage to picking up an area information when there are several stacked areas. Droping back to only showing the information when hovering over the actual boundary would make things a lot more usable. Firebug goes beserk tracking things that are changing and often sits toggling between two areas even without the mouse moving.

@tyrasd
Copy link
Member Author

tyrasd commented Sep 26, 2013

Are there any plans of making a new release that includes this fix? It's been over a month now, and this bug seems to be really annoying out in the wild.

@jfirebaugh
Copy link
Member

Yes, I'm planning to do a 1.2 release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

4 participants