Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering of incomplete multipolygons wrong #2945

Closed
slhh opened this issue Jan 30, 2016 · 4 comments
Closed

Rendering of incomplete multipolygons wrong #2945

slhh opened this issue Jan 30, 2016 · 4 comments
Assignees
Labels
bug A bug - let's fix this! map-renderer An issue with how things are rendered in the map
Milestone

Comments

@slhh
Copy link
Contributor

slhh commented Jan 30, 2016

The following two bugs have been discovered using iD master.

When drawing an incomplete multipolygon, the virtual edge seems to start at the wrong vertex, or is this an intended feature indicating the MP is broken?
incomplete mp
How to reproduce: Draw a line, set to "Line", and add multipolygon.

When removing a member from the "all members" section the member is still shown as selected until ckicking in the map window.
mp with deleted member
How to reproduce: Select a multipolygon, remove one of its segmented outer members from "all members" section.

@bhousel
Copy link
Member

bhousel commented Feb 1, 2016

Not quite sure what to do about these.

I know some people will say we should tighten up the rules for adding and removing things from multipolygons in the raw member editor, but I'm kind of more inclined to just let people do what they want and then run validations for these errors later.

Would #2223 be ok instead?

@slhh
Copy link
Contributor Author

slhh commented Feb 2, 2016

There seems to be a misunderstanding. The title may be a ambiguous: I don't mean it is wrong to render incomplete multipolygons; but the current rendering of these incomplete multipolygons seems to have two bugs.

@jfirebaugh jfirebaugh added the bug A bug - let's fix this! label Feb 9, 2016
@bhousel
Copy link
Member

bhousel commented Mar 11, 2016

@slhh Can you retest these situations with the current release of iD?

c79c65f fixed a bug where the multipolygon rendering wouldn't update when member ways were changed. I don't know if it fixes this issue, but it might..

@slhh
Copy link
Contributor Author

slhh commented Mar 11, 2016

Unfortunately, both bugs do still exist using master deployment.

@bhousel bhousel added the map-renderer An issue with how things are rendered in the map label Sep 18, 2017
@quincylvania quincylvania self-assigned this Nov 22, 2019
@quincylvania quincylvania added this to the 2.16.1 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

No branches or pull requests

4 participants