Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember user's most used presets for nodes, ways and areas #4125

Closed
tbertels opened this issue Jul 2, 2017 · 5 comments
Closed

Remember user's most used presets for nodes, ways and areas #4125

tbertels opened this issue Jul 2, 2017 · 5 comments

Comments

@tbertels
Copy link

tbertels commented Jul 2, 2017

When adding a node, a way or an area, the user should be shown features suggestions based on what he adds the most, not just based on Taginfo (#3709). Taginfo shows the most added features in the past by all users everywhere in the world, so a feature may actually be very frequent now but not be added anymore because it has already been added, or may never be used by the actual user.

It could be based on the last 100 edits or so.
This could be done by storing (#3002):

  • the most used features in the last 100 edits (group "recent")
  • the same but the 100 edits before (group "old").
    Once the group "recent" reaches 100, the group "old" is removed, and the group "recent" becomes the group "old".
    With those 2 groups for nodes, ways and areas, so 6 groups in total.

It might be best to add an id number to each preset to reduce the size of the preferences.
The maximum storage use would be 3 x 2 x 100 x 4 (max feature id size 999 + the ";" character) x 3 (max 100 uses for each feature + the ":" character) = 7200 characters.
But hopefully less if the user uses some features more than once.

https://wiki.openstreetmap.org/wiki/API_v0.6#Preferences_of_the_logged-in_user says that we can upload maximum 150 preferences at once (255 characters each) (total of 38250 characters), but it doesn't say if we can store more in total.

id features

@bhousel
Copy link
Member

bhousel commented Jul 2, 2017

iD already does push recently used presets to the top of the preset list. It doesn't persist these recently used presets between sessions (see #590 for discussion)

iD only uses taginfo for filling suggestions of dropdown fields.

Can you share a screenshot of which part of iD you mean?

@tbertels
Copy link
Author

tbertels commented Jul 3, 2017

Screenshot added. ;)

@bhousel
Copy link
Member

bhousel commented Jul 3, 2017

@tbertels Thanks for the screenshot - as you edit, do your recently used presets appear at the top of this list?

Is this issue just that you want them to persist between sessions?

@tbertels
Copy link
Author

tbertels commented Jul 4, 2017

I'd like them to persist and, instead of showing just the last 4 used:

  • to be sorted by x times used
  • to show more than the 4 most used
  • to replace less useful presets shown below (Park, Hospital Grounds, etc. (why are these shown?) which should be put into existing or new groups, to be always shown at the bottom)

@bhousel
Copy link
Member

bhousel commented Jul 7, 2017

Thanks for the clarification @tbertels, I'm going to close here as a duplicate of #590.
What I'd really like to do is add some kind of configurable "Favorites" preset screen that persists between sessions, allows the user to put whatever presets they want there in whatever order, and even assign keyboard shortcuts to them. Look for this soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants