Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mode/rotate): polygonHull sometimes returns array of length 2 #6979

Closed
wants to merge 2 commits into from

Conversation

hackily
Copy link
Contributor

@hackily hackily commented Oct 28, 2019

d3_polygonHull() sometimes returns an array of length 2, which d3_polygonCentroid() cannot handle.

This adds a check, and falls back to using geoVecInterp().

This fixes #6977

@bhousel
Copy link
Member

bhousel commented Oct 28, 2019

Great catch @hackily! Thanks for the fix, and welcome! 👋

@bhousel
Copy link
Member

bhousel commented Oct 28, 2019

@hackily For fixes like this, can you target the 2.x branch? We're using master for development of iD v3, which won't be available for a while.

I ended up cherry picking the fix onto the 2.x branch and merging, that's why GitHub doesn't show it as merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotating multiple points blanks OSM data layer
2 participants