Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more attraction presets #7039

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Add more attraction presets #7039

merged 2 commits into from
Nov 11, 2019

Conversation

hikemaniac
Copy link
Contributor

This PR adds presets for

  • attraction=kiddie_ride
  • attraction=log_flume
  • attraction=swing_carousel

according to the wiki.

bhousel
bhousel suggested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @hikemaniac - just a few minor nitpicks..

data/presets/presets/attraction/kiddie_ride.json Show resolved Hide resolved
data/presets/presets/attraction/log_flume.json Outdated Show resolved Hide resolved
@bhousel bhousel merged commit faee3d5 into openstreetmap:master Nov 11, 2019
bhousel added a commit that referenced this pull request Nov 11, 2019
@bhousel
Reapply #7039 via branch '2.x'
9906245
@hikemaniac hikemaniac deleted the attractions branch November 11, 2019 19:44
@bhousel bhousel added this to the 2.16.1 milestone Nov 11, 2019
@quincylvania quincylvania mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hikemaniac @bhousel