Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to follow another way based on a new node #8749

Closed
1ec5 opened this issue Oct 13, 2021 · 0 comments · Fixed by #8773
Closed

Unable to follow another way based on a new node #8749

1ec5 opened this issue Oct 13, 2021 · 0 comments · Fixed by #8773
Labels
bug A bug - let's fix this!

Comments

@1ec5
Copy link
Collaborator

1ec5 commented Oct 13, 2021

The “follow” operation added in #8671 only works if the current way is connected to enough consecutive saved nodes on another way, but if one or more of those nodes is being added as part of the same changeset, the needs_more_initial_nodes message appears. (“This line can't follow a way because it isn't connected to enough consecutive points along a way.”)

To reproduce, draw a line with two points:

line

then draw another line that connects to it at two new points in the middle:

follow

Finally, press F to follow the original line.

I think this is because of these hasEntity() checks:

if (!lastNodeId || !secondLastNodeId || !startGraph.hasEntity(lastNodeId) || !startGraph.hasEntity(secondLastNodeId)) {

@1ec5 1ec5 added the bug A bug - let's fix this! label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant