Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete ways when part of route/boundary relations #2526

Closed
wants to merge 0 commits into from

Conversation

@systemed
Copy link
Collaborator

commented Feb 12, 2015

Simple patch to prevent ways being unthinkingly deleted from route or boundary relations.

The user can still delete a way which is part of such a relation by manually removing the way from the relation first, then deleting the way.

Fixes #1461.

@tmcw

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2015

LGTM: it does swing the dial from overly lax to pretty strict, but there's a clear way to act on the disabled-message which is good. @jfirebaugh want to review for merge?

@KathleenLD

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2015

👯

@jfirebaugh

This comment has been minimized.

Copy link
Member

commented Feb 12, 2015

Looks good to me. Based on the feedback in #1461 I suggest we expand this to at least the outer ways of multipolygon relations.

I'd also like to put in a modifier key escape hatch for experienced editors. E.g. hold down alt or shift to bypass the prohibition. If you want to tackle that let me know, otherwise I can merge this and add it myself later.

@systemed

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 12, 2015

No problem - I've added a check for multipolygon outers. I'll let you do the modifier key bit!

@jfirebaugh jfirebaugh force-pushed the warn_relations branch from 8148db3 to 9cd836a Feb 12, 2015

@jfirebaugh jfirebaugh closed this Feb 12, 2015

@jfirebaugh jfirebaugh force-pushed the warn_relations branch from 9cd836a to 9aab74c Feb 12, 2015

@jfirebaugh

This comment has been minimized.

Copy link
Member

commented Feb 12, 2015

I really confused GitHub with some force pushing, but this was merged.

@jfirebaugh jfirebaugh deleted the warn_relations branch Feb 12, 2015

@systemed

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 12, 2015

Excellent, thank you!

@KathleenLD

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2015

Nice work, guys!

@brycenesbitt

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2015

Thank you for this, it was much needed, and will save significant future hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.