make sure DrawLine mode is called with a clean pre-operation graph #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfirebaugh can you please take a look and review this PR (considering the changes in 8a215ca#diff-dca22f16b0f009e9ff9c946ca989cb99)? |
|
Yes, I see what's going on -- The reason I could never reproduce this issue is that Mac keyboards do not have a key that triggers this action. They have a "delete" key but it does what a PC keyboard calls "backspace". |
tyrasd
added a commit
that referenced
this pull request
Jan 26, 2016
make sure DrawLine mode is called with a clean pre-operation graph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #2303.