Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farsi translation uses arabic commas in 'terms' #472

Open
lonvia opened this issue May 28, 2022 · 2 comments
Open

Farsi translation uses arabic commas in 'terms' #472

lonvia opened this issue May 28, 2022 · 2 comments
Labels

Comments

@lonvia
Copy link

lonvia commented May 28, 2022

The Farsi translation of the presets consistently uses the arabic comma (U+060C) for separating 'terms'. Example:

"terms": "کتیبه، نوشته، توصیف"

Is this an error on the translation side or should software accept both normal and arabic comma as a separator?

@1ec5
Copy link
Contributor

1ec5 commented May 28, 2022

I’d be inclined to call it an error, but it probably wouldn’t hurt to add the Arabic comma as an alternative delimiter. Every project that uses this localizations (such as Go Map!!) would need to make the same change, even though the localizations are nominally part of the iD project.

This would be a good argument for replacing the comma with a newline as the standard delimiter. That would be consistent with aliases and also remove ambiguity as to whether a space is required after the comma. I think changing the delimiter would require a change to both iD and id-tagging-schema, if not also schema-builder.

@westnordost
Copy link
Contributor

Changing it to newlines may be consistent (with aliases), though it would (unnecessarily) break backward compatibility.

IF backward compatibility is broken, I would suggest (instead) to change the build script(s) that create the files in dist to already return the terms and aliases as an array of strings instead of letting the clients (iD, osmfeatures, nominatim, Go Map!! etc...) deal with splitting the string (and removing any whitespaces around the terms etc.).
However it is presented to translators on Transifex is then something that will be separate of this anyway.

If backward compatibility should not be broken, I'd suggest to at least let the build script deal with things like this.

I think breaking backward compatibility is not that big of a deal, after all, this project uses proper versioning and it has been broken a couple of times in the last years. (IIRC last time was when the brand presets were separated out from the generic iD presets but I may be mistaken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants