Use lazy translation lookups for the user_blocks partials #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the heads up. |
|
As you've only changed the english messages I don't think this will affect @Nikerabbit as such, but it does mean those messages will have to be translated again. |
|
After the PR is merged, I will apply the renames to also translations so they don't actually need to be translated again. |
|
OK. I've merged it now if you want to do your magic. |
|
It looks like everything was renamed on translatewiki - thanks @Nikerabbit ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy translations are easier to read, to write, and easier to deal with when refactoring things like partial names, controller methods and controller names.
This is just a first gentle step in a wider project.
@Nikerabbit as per #1289 this PR will involve changing translation keys on Translatewiki, if it is merged.