Friendly error msg for missing iD key in application.yml #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A blank id key will show an "iD has not been configured" popup when starting iD. Fixes #1830
|
I would say b73825e is obsolete now, it could probably be reverted. |
|
Obsoleted by #2177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fall back to an empty iD key in case it hasn't been maintained in application.yml yet.
This way, a user will see an "iD has not been configured" popup when starting iD, instead of a stack trace with "uninitialized constant ActionView::CompiledTemplates::ID_KEY" on it.
Fixes #1830