Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.86.0 to 0.87.0 #2692

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2020

Bumps rubocop from 0.86.0 to 0.87.0.

Release notes

Sourced from rubocop's releases.

RuboCop 0.87

New features

  • #7868: Cop::Base is the new recommended base class for cops. (@marcandre)
  • #3983: Add new Style/AccessorGrouping cop. (@fatkodima)
  • #8244: Add new Style/BisectedAttrAccessor cop. (@fatkodima)
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. (@fatkodima)
  • #7373: Add new Style/RedundantAssignment cop. (@fatkodima)
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). (@koic)
  • #8159: Add new CountAsOne option for code length related Metric cops. (@fatkodima)
  • #8164: Support auto-correction for Lint/InterpolationCheck. (@koic)
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. (@koic)
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. (@koic)

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. (@CamilleDrapier)
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. (@fatkodima)
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. (@koic)
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. (@owst)
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. (@owst)
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. (@karlwithak)
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. (@deivid-rodriguez)

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. (@marcandre)
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. (@marcandre)
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. (@marcandre)
  • #8211: Style/ClassVars cop now detects class_variable_set. (@biinari)
  • #8245: Detect top-level constants like ::Const in various cops. (@biinari)
Changelog

Sourced from rubocop's changelog.

0.87.0 (2020-07-06)

New features

  • #7868: Cop::Base is the new recommended base class for cops. ([@marcandre][])
  • #3983: Add new Style/AccessorGrouping cop. ([@fatkodima][])
  • #8244: Add new Style/BisectedAttrAccessor cop. ([@fatkodima][])
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. ([@fatkodima][])
  • #7373: Add new Style/RedundantAssignment cop. ([@fatkodima][])
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). ([@koic][])
  • #8159: Add new CountAsOne option for code length related Metric cops. ([@fatkodima][])
  • #8164: Support auto-correction for Lint/InterpolationCheck. ([@koic][])
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. ([@koic][])
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. ([@koic][])

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. ([@CamilleDrapier][])
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. ([@fatkodima][])
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. ([@koic][])
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. ([@owst][])
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. ([@owst][])
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. ([@karlwithak][])
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. ([@deivid-rodriguez][])

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. ([@marcandre][])
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. ([@marcandre][])
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. ([@marcandre][])
  • #8211: Style/ClassVars cop now detects class_variable_set. ([@biinari][])
  • #8245: Detect top-level constants like ::Const in various cops. ([@biinari][])
Commits
  • ba8f13a Cut 0.87
  • 040e829 Changelog entry for #8245
  • 5e03e9b Allow top-level const in MutableConst
  • 91820ea Detect top-level const in ExpandPathArguments
  • bc268f8 Detect top-level const in RandomWithOffset
  • a59d579 Detect redundant ::RuntimeError in raise/fail
  • ce20cb4 Detect ::ENV in Style/RedundantFreeze
  • dbc3794 Allow top-level const in Style/ZeroLengthPredicate
  • d0de34a Allow ::Proc.new with arg in Style/SymbolProc
  • d499386 Detect ::Struct in Style/StructInheritance
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 7, 2020
@tomhughes
Copy link
Member

This breaks erb-lint - Shopify/erb-lint#179 is pending upstream to fix it.

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.87.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.86.0...v0.87.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-0.87.0 branch from 6571837 to 582739f Compare July 7, 2020 09:50
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 8, 2020

Superseded by #2694.

@dependabot dependabot bot closed this Jul 8, 2020
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-0.87.0 branch July 8, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant