Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 0.86.0 to 0.87.1 #2694

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 8, 2020

Bumps rubocop from 0.86.0 to 0.87.1.

Release notes

Sourced from rubocop's releases.

RuboCop 0.87.1

Bug fixes

  • #8252: Fix a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.86 and lower. (@koic)
  • #8259: Fix false positives for Style/BisectedAttrAccessor when accessors have different access modifiers. (@fatkodima)
  • #8253: Fix false positives for Style/AccessorGrouping when accessors have different access modifiers. (@fatkodima)
  • #8257: Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments. (@fatkodima)
  • #8239: Don't load .rubocop.yml from personal folders to check for exclusions if given a custom configuration file. (@deivid-rodriguez)
  • #8256: Fix an error for --auto-gen-config when running a cop who do not support auto-correction. (@koic)
  • #8262: Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use lower case, as some Linux-based systems do not accept upper cased cipher names. (@bdewater)

RuboCop 0.87

New features

  • #7868: Cop::Base is the new recommended base class for cops. (@marcandre)
  • #3983: Add new Style/AccessorGrouping cop. (@fatkodima)
  • #8244: Add new Style/BisectedAttrAccessor cop. (@fatkodima)
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. (@fatkodima)
  • #7373: Add new Style/RedundantAssignment cop. (@fatkodima)
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). (@koic)
  • #8159: Add new CountAsOne option for code length related Metric cops. (@fatkodima)
  • #8164: Support auto-correction for Lint/InterpolationCheck. (@koic)
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. (@koic)
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. (@koic)

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. ([@CamilleDrapier][])
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. (@fatkodima)
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. (@koic)
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. ([@owst][])
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. ([@owst][])
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. ([@karlwithak][])
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. (@deivid-rodriguez)

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. (@marcandre)
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. (@marcandre)
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. (@marcandre)
  • #8211: Style/ClassVars cop now detects class_variable_set. ([@biinari][])
  • #8245: Detect top-level constants like ::Const in various cops. ([@biinari][])
Changelog

Sourced from rubocop's changelog.

0.87.1 (2020-07-07)

Bug fixes

  • #8252: Fix a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.86 and lower. ([@koic][])
  • #8259: Fix false positives for Style/BisectedAttrAccessor when accessors have different access modifiers. ([@fatkodima][])
  • #8253: Fix false positives for Style/AccessorGrouping when accessors have different access modifiers. ([@fatkodima][])
  • #8257: Fix an error for Style/BisectedAttrAccessor when using attr_reader and attr_writer with splat arguments. ([@fatkodima][])
  • #8239: Don't load .rubocop.yml from personal folders to check for exclusions if given a custom configuration file. ([@deivid-rodriguez][])
  • #8256: Fix an error for --auto-gen-config when running a cop who do not support auto-correction. ([@koic][])
  • #8262: Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use lower case, as some Linux-based systems do not accept upper cased cipher names. ([@bdewater][])

0.87.0 (2020-07-06)

New features

  • #7868: Cop::Base is the new recommended base class for cops. ([@marcandre][])
  • #3983: Add new Style/AccessorGrouping cop. ([@fatkodima][])
  • #8244: Add new Style/BisectedAttrAccessor cop. ([@fatkodima][])
  • #7458: Add new AsciiConstants option for Naming/AsciiIdentifiers. ([@fatkodima][])
  • #7373: Add new Style/RedundantAssignment cop. ([@fatkodima][])
  • #8213: Permit to specify TargetRubyVersion 2.8 (experimental). ([@koic][])
  • #8159: Add new CountAsOne option for code length related Metric cops. ([@fatkodima][])
  • #8164: Support auto-correction for Lint/InterpolationCheck. ([@koic][])
  • #8223: Support auto-correction for Style/IfUnlessModifierOfIfUnless. ([@koic][])
  • #8172: Support auto-correction for Lint/SafeNavigationWithEmpty. ([@koic][])

Bug fixes

  • #8039: Fix false positives for Lint/ParenthesesAsGroupedExpression in when using operators or chain functions. ([@CamilleDrapier][])
  • #8196: Fix a false positive for Style/RedundantFetchBlock when using with Rails.cache. ([@fatkodima][])
  • #8195: Fix an error for Style/RedundantFetchBlock when using #fetch with empty block. ([@koic][])
  • #8193: Fix a false positive for Style/RedundantRegexpCharacterClass when using [\b]. ([@owst][])
  • #8205: Fix a false positive for Style/RedundantRegexpCharacterClass when using a leading escaped ]. ([@owst][])
  • #8208: Fix Style/RedundantParentheses with hash literal as first argument to yield. ([@karlwithak][])
  • #8176: Don't load .rubocop.yml from personal folders to check for exclusions if there's a project configuration. ([@deivid-rodriguez][])

Changes

  • #7868: (Breaking) Extensive refactoring of internal classes Team, Commissioner, Corrector. Cop::Cop#corrections not completely compatible. See Upgrade Notes. ([@marcandre][])
  • #8156: (Breaking) rubocop -a / --autocorrect no longer run unsafe corrections; rubocop -A / --autocorrect-all run both safe and unsafe corrections. Options --safe-autocorrect is deprecated. ([@marcandre][])
  • #8207: (Breaking) Order for gems names now disregards underscores and dashes unless ConsiderPunctuation setting is set to true. ([@marcandre][])
  • #8211: Style/ClassVars cop now detects class_variable_set. ([@biinari][])
  • #8245: Detect top-level constants like ::Const in various cops. ([@biinari][])
Commits
  • de0f2e8 Cut 0.87.1
  • 9b2ff38 Fix false positives for Style/BisectedAttrAccessor when accessors have diff...
  • 698a17f Merge pull request #8262 from bdewater/openssl-lower-case-constant
  • d8541a4 Fix Lint/DeprecatedOpenSSLConstant auto-correction of OpenSSL::Cipher to use ...
  • caef6bb Fix false positives for Style/AccessorGrouping when accessors have differen...
  • 85ff4c3 Fix an error for Style/BisectedAttrAccessor when using attr_reader and `a...
  • 0d09c1b [Fix #8256] Fix an error for --auto-gen-config when running a cop without a...
  • 5bcf201 [Docs] Tweak some markup
  • ee4f5dc Add a note about the --config flag
  • a743015 Don't load exclusions from personal files when passing a config with custom name
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.87.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v0.86.0...v0.87.1)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 8, 2020
@gravitystorm
Copy link
Collaborator

As per #2692:

This breaks erb-lint - Shopify/erb-lint#179 is pending upstream to fix it.

@gravitystorm gravitystorm marked this pull request as draft July 9, 2020 11:25
@gravitystorm gravitystorm added the awaiting upstream We are waiting for code from other project, like Rails or a Gem label Jul 9, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 14, 2020

Superseded by #2706.

@dependabot dependabot bot closed this Jul 14, 2020
@dependabot dependabot bot deleted the dependabot/bundler/rubocop-0.87.1 branch July 14, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting upstream We are waiting for code from other project, like Rails or a Gem dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant