Introduce "reload" js controller method #3774
Conversation
app/assets/javascripts/router.js
Outdated
| @@ -179,8 +187,20 @@ OSM.Router = function (map, rts) { | |||
| }; | |||
|
|
|||
| router.load = function () { | |||
| var loadState = currentRoute.run("load", currentPath); | |||
| var loadState = loadOrReload(); | |||
There was a problem hiding this comment.
What's the reason for putting this logic in a nested function if this is the only user?
There was a problem hiding this comment.
Are you asking why it's nested or why it's defined when there's only one caller?
The short answer is to initialize var loadState when it's declared.
There was a problem hiding this comment.
I'm asking why put the logic in a function rather than just having it inline.
Are you saying that function is only called once rather than each time the load function is invoked?
There was a problem hiding this comment.
Of course loadOrReload is called as many times as router.load.
There was a problem hiding this comment.
Changed it to extra variable instead of extra function.
app/assets/javascripts/router.js
Outdated
| if (currentRoute.has("reload") && window.performance) { | ||
| var wasReloaded = window.performance.getEntriesByType("navigation").some(function (entry) { | ||
| return entry.type === "reload"; | ||
| }); |
There was a problem hiding this comment.
I'm not familiar with window.performance but from a quick bit of reading on MDN it seems this if testing if there are any navigation events of type reload in the history but what's the scope of that? The comment you added says we're interest in whether this request was a reload?
There was a problem hiding this comment.
I think it's for the current page only, not for the history.
https://developer.mozilla.org/en-US/docs/Web/API/Performance : "The Performance interface provides access to performance-related information for the current page".
AntonKhorev
force-pushed
the
changeset-list-state--router-reload
branch
from
8f8e5de
to
593f554
Compare
Part of 2d18621.
This is a method that gets called
Otherwise the usual "load" method is called.
If any kind of client-side caching is used, js controllers can flush the cache in this method.