New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move copyright link to attribution control #423
Conversation
I don't have a problem with putting this in the standard attribution, but I'd really like to hear what other people think about removing this from the side bar. In the context of our site this link is about more than just providing attribution for the pretty map - it's a key link for providing information about how to engage with using our data and I worry about reducing it's prominence. I think @systemed created it originally so maybe he has some thoughts? or any of the LWG people? |
|
There's an argument to be made both ways. jfirebaugh has a point about the "canonical example" - we've had people in the past acting surprised about having to add attribution, saying "but OSM itself doesn't have it". But tomhughes has a point about "reducing prominence". Nobody looks at the small print in the corner of a map - for us, the license is an essential part of what we're doing, not some footnote "btw we got our map from provider X". Suggestion:
|
I see three issues:
I wouldn't be opposed to adding the attribution on the OSM Mapnik layer for instructional value. It isn't like we can use that corner for displaying something else, after all we need it for credit for the other layers. |
I fully agree with other commentators - have both. |
If you're going to add "© OpenStreetMap contributors" to the standard layer (which I support as part of the 'have both' discussion above), then you should probably also add "Data © OpenStreetMap contributors" to all the other layer attributions at the same time. And if we are showing 'how it should be done', then perhaps instead of using Andy's name on the transport and cycle layers, we should mention Thunderforest as per his terms and conditions http://thunderforest.com/terms/ |
This pull does add it to all the layers (it doesn't have the "Data" prefix though). As to the credit on the @gravitystorm layers I have already told him to shout if he wants me to change it to Thunderforest. |
+1 to having it both on the map and in the sidebar. It's not just the attribution for the map; it's our instructions on how to use OSM data legally (and heaven knows enough people seem to have some inexplicable difficulty doing that...). |
Ok, restored existing link and moved it to "Data". |
Merged. |
Its current location, under "Help" in the sidebar, feels a bit out of place -- information about OSM copyright and license is not really "Help".
Placing it in the standard Leaflet attribution control also has the benefit of being something we can point to as a canonical example of an acceptable way to attribute OSM.