Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Glow to Search Box #491

Closed
wants to merge 2 commits into from
Closed

Conversation

ingalls
Copy link
Contributor

@ingalls ingalls commented Sep 24, 2013

The black focus border around the search bar really doesn't fit with the theme of the site. A green glow really cleans it up.

@tmcw
Copy link
Contributor

tmcw commented Sep 24, 2013

This should be one of the site-wide greens rather than the CSS green, if we do this.

@tomhughes
Copy link
Member

Well it's presumably a bit pointless anyway given that we expect to be replacing the whole sidebar in the near future? or at least it would only be a stop gap.

Maybe you could add a picture @MaltaProject so that we can see how it will look?

@ingalls
Copy link
Contributor Author

ingalls commented Sep 25, 2013

screenshot from 2013-09-24 23 33 02

Here is a screenshot showing the glow with the new green. I used the lighter green from behind the view tab which I'm assuming is the one you were referring to.

@pnorman
Copy link
Contributor

pnorman commented Sep 25, 2013

👍

@jfirebaugh
Copy link
Member

Looks good to me, and this is something we'd keep around in a redesign anyway.

@ingalls
Copy link
Contributor Author

ingalls commented Sep 25, 2013

Awesome, glad to hear!

@tomhughes
Copy link
Member

It actually looks much better than I was expecting, and I quite like it... Merged.

@tomhughes tomhughes closed this Sep 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants