Update geocoder.search_osm_nominatim.prefix.aerialway #859

pyrog · 2014-12-18T11:03:40Z

Update geocoder.search_osm_nominatim.prefix.aerialway

Icons for highway=tertiary, highway=track, highway=path and barrier=wall.

Fixes #825

Phusion Passenger has documentation for common web servers, so we can link to them, as most users will be using one of them in production.

Postgres 8.3 is EOL and the minimum version supported by PostgreSQL is 9.0. The production servers run 9.1, and the extension setup is easier with it too.

Fixes #830

This reverts commit 15a7276.

Fixes #838

The index view doesn't render any pagination controls, and there aren't enough redactions for pagination to be necessary yet. Fixes #735

The local variable `app` was unused and therefore not needed to be declared with initialization

related: openstreetmap/iD#2475

tomhughes · 2014-12-18T11:18:35Z

config/locales/en.yml

@@ -107,7 +107,7 @@ en:
    in_changeset: "Changeset"
    anonymous: "anonymous"
    no_comment: "(no comment)"
-    part_of: "Part of"
+    part_of: "Part of"aer


Is this an intended change?

It was a mistake. I will add another commit for bridges and I'll check this

tomhughes · 2014-12-18T11:20:59Z

Are these new values that nominatim has started returning or something?

I'm trying to remember how we normally handle these values - do you normally generate them from nominatim or something @lonvia?

pyrog · 2014-12-18T11:39:57Z

I see that there is bridge:movable key. How to add theses values for translations ?

        bridge:
          movable:  "Movable Bridge"
            drawbridge: "Draw Bridge"
            lift: "Lift Bridge"

tomhughes · 2014-12-18T11:42:22Z

@pyrog you probably want to wait for @lonvia before you do any more work on this as I don't know yet if we're going to want to take these directly or only via nominatim.

The answer to your question is just to quote the key.

pyrog · 2014-12-18T12:04:41Z

This way ?

        bridge:
            …
        "bridge:movable":
            bascule: "Bascule Bridge"
            drawbridge: "Draw Bridge"
            lift: "Lift Bridge"
            submersible: "Submersible Bridge"
            swing: "Swing Bridge"
            transporter: "Transporter Bridge"
            retractable: "Retractable Bridge"

@pyrog you probably want to wait for @lonvia before you do any more work on this

Yes, of course 😄

lonvia · 2014-12-18T13:39:37Z

@tomhughes No objection to merging this.

There's no automatic updates of these terms. I simply go through the database from time to time and add terms that have come into fashion.

pyrog · 2014-12-18T15:04:23Z

I had also emergency=defibrillator to Nominatim/Special_Phrases/FR.

Could you merge theses commits plus Nominatim/Special_Phrases/FR please ?

lonvia · 2014-12-18T15:15:07Z

Those special phrases have nothing to do with the website.

lonvia · 2014-12-18T15:15:43Z

config/locales/en.yml

+            submersible: "Submersible Bridge"
+            swing: "Swing Bridge"
+            transporter: "Transporter Bridge"
+            retractable: "Retractable Bridge"       


Those bridge:movable tags are pointless, Nominatim doesn't index them.

pyrog · 2014-12-18T15:26:26Z

Those special phrases have nothing to do with the website.

@lonvia of course, but they have to do with emergency=defibrillator translation 😉
Do you want that I open another issue in Nominatim project ?

lonvia · 2014-12-18T15:46:12Z

It would have been a better place because it would have a better chance to be seen by the people who can merge the special phrases.

tomhughes · 2015-02-01T10:17:54Z

I've just merged #887 from @lonvia which updates the terms.

dankarran and others added 30 commits November 4, 2014 09:56

Add some missing browse icons

0440984

Icons for highway=tertiary, highway=track, highway=path and barrier=wall.

Add comments_feed action to various filters

260a690

Fixes #825

Link to Phusion Passenger docs for production

4877799

Phusion Passenger has documentation for common web servers, so we can link to them, as most users will be using one of them in production.

Recommend PostgreSQL 9.1+ in database.yml

295c4f6

Postgres 8.3 is EOL and the minimum version supported by PostgreSQL is 9.0. The production servers run 9.1, and the extension setup is easier with it too.

Merge branch 'overpass'

e11d734

Don't do the admin boundary special case unless admin_level is set

cddec72

Look for locale specific names

2992564

Allow query mode to be turned off at low zoom

526ff06

Fixes #830

Handle unknown admin_level values

4abb666

Track users in piwik

08a0fc9

Update to rails 4.1.7

ac2f930

Revert "Add SOTM advert"

f0ecc63

This reverts commit 15a7276.

Stringify user ID

89af923

Localisation updates from https://translatewiki.net.

1f956ad

Update to rails 4.1.8

dc9f779

Update attribution for embedded maps

33bcb2e

Fixes #838

Update vendor URLs

aeb5240

Update html5shiv

ab671bd

Update jQuery plugins

557dcd8

Update ohauth

a994f5d

Don't paginate redactions

eb6b1ae

The index view doesn't render any pagination controls, and there aren't enough redactions for pagination to be necessary yet. Fixes #735

Make sure button_to buttons are separated by whitespace

3dbc55f

Include number of recent diary entries in spam scoring

4d44f18

Prefer a key=value match over a key only match for object descriptions

b00b156

Fix exception when message limit is hit

36592f7

Fix typo

f2c23d1

Losslessly compressed all images using optipng and advpng

b1a1d45

Remove unnecessary local variable

9934eed

The local variable `app` was unused and therefore not needed to be declared with initialization

Update bundle

1bfc96e

Query mode doesn't need the database

a6c24e3

tomhughes and others added 5 commits December 14, 2014 00:27

Disable the "add note" button in database offline mode

281dc29

Make development mode work when the database is offline

2b823b7

Don't render the offline page for XHR requests

4e6fe81

Don't raise APIAlreadyDeletedError when deleting with if-unused

068471f

related: openstreetmap/iD#2475

Update geocoder.search_osm_nominatim.prefix.aerialway

0862ba0

tomhughes reviewed Dec 18, 2014
View reviewed changes

pyrog added 2 commits December 18, 2014 15:58

Update geocoder.search_osm_nominatim.prefix.bridge

e398e0e

Add geocoder.search_osm_nominatim.prefix.emergency

0a127e2

lonvia reviewed Dec 18, 2014
View reviewed changes

Remove "bridge:movable subkeys because they are not indexed by Nominatim

baf9e33

openstreetmap-mirror force-pushed the master branch from 068471f to d87ea68 Compare December 19, 2014 01:20

tomhughes closed this Feb 1, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update geocoder.search_osm_nominatim.prefix.aerialway #859

Update geocoder.search_osm_nominatim.prefix.aerialway #859

pyrog commented Dec 18, 2014

tomhughes Dec 18, 2014

pyrog Dec 18, 2014

tomhughes commented Dec 18, 2014

pyrog commented Dec 18, 2014

tomhughes commented Dec 18, 2014

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

lonvia Dec 18, 2014

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

tomhughes commented Feb 1, 2015

Update geocoder.search_osm_nominatim.prefix.aerialway #859

Update geocoder.search_osm_nominatim.prefix.aerialway #859

Conversation

pyrog commented Dec 18, 2014

tomhughes Dec 18, 2014

Choose a reason for hiding this comment

pyrog Dec 18, 2014

Choose a reason for hiding this comment

tomhughes commented Dec 18, 2014

pyrog commented Dec 18, 2014

tomhughes commented Dec 18, 2014

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

lonvia Dec 18, 2014

Choose a reason for hiding this comment

pyrog commented Dec 18, 2014

lonvia commented Dec 18, 2014

tomhughes commented Feb 1, 2015