Update to iD v1.7.0 #898
Merged
Update to iD v1.7.0 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| .embed(true) | ||
| .assetPath("/iD/") <%# Can't use asset_path('iD/') in production. %> | ||
| .assetPath("/iD/") <%# Cant use asset_path('iD/') in production. %> |
There was a problem hiding this comment.
Was there a reason for removing the apostrophe here?
There was a problem hiding this comment.
Just because it was wrecking the syntax highlighting in the rest of the file.
There was a problem hiding this comment.
Ha, I obviously have a better editor than you (insert standard editor war here)
There was a problem hiding this comment.
hehe, you have a better editor than Github too!
|
So that works fine, but iD is still saying |
oops! missed that one, but it should be right now... |
|
thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying again..
@tomhughes @jfirebaugh