Option to enable Verbose output to run tab + styled fallback when no socket #513
Conversation
…d consider removing the socket and just use stdout
… and socket at the same time (not supported)
…tyle everything, but won't be using it as default since the E+ status updates aren't live (missing a flush in os CLI / workflow gem probably)
jmarrec
added
Enhancement Request
| } else { | ||
| // If not verbose, we save the stdout/stderr to a file, like historical | ||
| // Actually, we don't, we just read it | ||
| // m_runProcess->setStandardOutputFile(toQString(stdoutPath)); |
There was a problem hiding this comment.
Will E+ stdout and stderr still be in files in the sim dir for the user to read later? I see stdout-energyplus and stderr-energyplus files but I'm not entirely sure which process was writing those, the app or the cli.
There was a problem hiding this comment.
stdout-energyplus stderr-energyplus are written by workflow gem.
What I am no longer outputing is the model_companion_dir/stdout and stderr files. I see no value in keeping those, when we are seeing them live. I don't see any use case for seeing them afterwards, but perhaps there is one. In which case the RunView::readyReadStandardOutput and RunView::readyReadStandardError should be writting to these files in append mode in addition of displaying them live. thoughts @macumber ?
There was a problem hiding this comment.
Ok yeah, I don't think those two files are useful. Thanks Julian!
jmarrec
force-pushed
the
110_workflow_stdout
branch
from
4411071
to
dd97abe
Compare
Fixes Hard to see errors generated in ModelToIdf job in App #110
Fixes No error message for failed simulation with empty spaces #437
Add a "verbose output" checkbox to the run tab
This is saved in the user preferences
When enabled, this will do openstudio --verbose run -w workflow.osw, and style the stdout/stderr
When no socket can be opened, the fallback will also be styled similarly to when sockets are used