Update mechanical ventilation outdoor air method combo box #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
requested changes
Dec 11, 2023
| ventilationCalcMethodComboBox->addItem("Indoor Air Quality Procedure Generic Contaminant", "IndoorAirQualityProcedureGenericContaminant"); | ||
| ventilationCalcMethodComboBox->addItem("Indoor Air Quality Procedure Combined", "IndoorAirQualityProcedureCombined"); | ||
| ventilationCalcMethodComboBox->addItem("Proportional Control Bseed On Design Occupancy", "ProportionalControlBasedOnDesignOccupancy"); | ||
| ventilationCalcMethodComboBox->addItem("Proportional Control Bseed On Design OA Rate", "ProportionalControlBasedOnDesignOARate"); |
There was a problem hiding this comment.
These aren't one of the values that OpenStudio.idd has though.
A5, \field System Outdoor Air Method
\type choice
\key ZoneSum
\key Standard62.1VentilationRateProcedure
\key Standard62.1VentilationRateProcedureWithLimit
\key IndoorAirQualityProcedure
\key ProportionalControl
\key ProportionalControlBasedOnOccupancySchedule
\key ProportionalControlBasedOnDesignOccupancy
There was a problem hiding this comment.
I filed NREL/OpenStudio#5060 for it, but we can't drop this PR with options that don't exist in 3.7.0
jmarrec
requested changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634
@jmarrec