Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] 升级到 React 18 #861

Closed
bytemain opened this issue Apr 18, 2022 · 14 comments
Closed

[RFC] 升级到 React 18 #861

bytemain opened this issue Apr 18, 2022 · 14 comments
Assignees
@Ricbet
Labels
💪 enhancement New feature or request 🎨 feature feature required

Comments

@bytemain
Copy link
Member

React 18 有较好的性能提升，并且提供了 Concurrent Mode 给开发者来控制高低优先级的渲染。

看起来值得升级。
@bytemain bytemain added the 🎨 feature feature required label Apr 18, 2022
@bytemain bytemain mentioned this issue Apr 27, 2022
Closed
1 task
@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 👾 wontfix label Oct 12, 2022
@erha19 erha19 added 🤔 help wanted Extra attention is needed and removed 👾 wontfix labels Oct 13, 2022
@erha19
Copy link
Member

erha19 commented Oct 13, 2022

已在 #970, 由于对集成侧组件库存在影响，暂时搁置

@l1shen
Copy link
Contributor

l1shen commented Feb 23, 2023

请问升级 React 18 有什么进展吗

@erha19
Copy link
Member

erha19 commented Feb 23, 2023

请问升级 React 18 有什么进展吗

@l1shen 近期正在做部分组件迁移上的改造，下周会继续这个升级计划

@erha19 erha19 added 💪 enhancement New feature or request and removed 🤔 help wanted Extra attention is needed labels Feb 23, 2023
@Ricbet Ricbet self-assigned this Mar 6, 2023
@Ricbet Ricbet pinned this issue Mar 6, 2023
@Ricbet Ricbet linked a pull request Mar 14, 2023 that will close this issue
refactor: upgrade to react 18 #2404
Closed
1 task
@erha19 erha19 mentioned this issue Mar 15, 2023
Closed
@Ricbet
Copy link
Member

Ricbet commented Mar 15, 2023 •
edited
Loading

目前升上去后能正常 work，功能验证也没问题，但依赖的 mobx 会在控制台报以下错误，提示说在渲染过程中尝试更新另一个组件的状态和属性
image
可能需要调整一些代码来规避。

然后本来想升级 mobx，但目前对方还处于 WIP mobxjs/mobx#3005, 所以 mobx 版本保持不变

actions

  • 解决升级导致 mobx 报错的问题

@Ricbet Ricbet unpinned this issue Mar 22, 2023
@erha19
Copy link
Member

erha19 commented May 4, 2023

看起来好像在 mobx-react-lite@3.4.0 已经解决这个问题了？ @Ricbet

@Ricbet
Copy link
Member

Ricbet commented May 4, 2023

看起来好像在 mobx-react-lite@3.4.0 已经解决这个问题了？ @Ricbet

晚点再看看

@BlackHole1
Copy link
Contributor

Hey @erha19 @Ricbet 👋，目前这个 RFC 有什么新的进展么？

@bytemain
Copy link
Member Author

bytemain commented Jun 8, 2023

rc-xxx 和 antd 之类是不是也需要升一升

@BlackHole1
Copy link
Contributor

BlackHole1 commented Jun 8, 2023 •
edited
Loading

rc-xxx 和 antd 之类是不是也需要升一升

@bytemain 看起来可以放在另一个 PR 中🤔，可以让升级至 React 18 保持“最小实现”，只升级所必须的 library。以保证 PR 的整洁。

@Ricbet
Copy link
Member

Ricbet commented Jun 8, 2023

Hey @erha19 @Ricbet 👋，目前这个 RFC 有什么新的进展么？

目前主要是 mobx 依赖问题。升级 mobx 有较大的 bk，不升级 mobx 又有 waring 的报错问题（不过这个不影响功能的使用）
这块如果您有兴趣，可以一起来贡献一下～

@BlackHole1
Copy link
Contributor

@Ricbet 那看起来可以先合并 #2404 并进行发版，因为 mobx warning 并不会影响实际的业务功能。
Mobx 升级可以再另启一个 PR 去做（我可以尝试看一下）

@AhkunTa AhkunTa mentioned this issue Oct 7, 2023
Closed
@erha19 erha19 mentioned this issue Nov 16, 2023
Merged
1 task
@erha19
Copy link
Member

erha19 commented Dec 7, 2023

@BlackHole1 已完成

@erha19 erha19 closed this as completed Dec 7, 2023
@BlackHole1
Copy link
Contributor

感谢你们的工作！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ricbet Ricbet

Labels
💪 enhancement New feature or request 🎨 feature feature required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: react 18 opensumi/core
refactor: upgrade to react 18 opensumi/core
5 participants
@BlackHole1 @l1shen @erha19 @bytemain @Ricbet