Default value for optional parameters #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
reviewed
Oct 17, 2016
| var _ = require('underscore'); | ||
|
|
||
| module.exports = function(requestParameters, expectedParameters) { | ||
| var result = _.clone(requestParameters); |
There was a problem hiding this comment.
is this clone necessary? If a component has a decent number of params (like TMS) this clone could use some CPU. If not necessary, I would be tempted to remove it? What do you think
| module.exports = function(requestParameters, expectedParameters) { | ||
| var result = _.clone(requestParameters); | ||
| var optionalParametersWithDefaults = _.pick(expectedParameters, function(parameter){ | ||
| return !parameter.mandatory && parameter.default; |
There was a problem hiding this comment.
what when parameter.default is a boolean false? maybe a !_.isUndefined(parameter.default) would be better?
|
🎉 🎂 |
|
Thanks! I updated the wiki too. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #276
Would require change in wiki -> Getting started page:
|
oc.parameters[key].default|*|Default value of optional parameter - applied when value is not specified in the request|