-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for installing the windows features required for iis #26
adding support for installing the windows features required for iis #26
Conversation
@@ -0,0 +1,6 @@ | |||
class iis::features::application_deployment { | |||
ensure_resource('windowsfeature', 'Web-Asp-Net' ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not quite sure we can do this - there may be different features needed for a 4.0 or a 4.5 account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I need to do an IIS8 installation and see what's there. I'll put this on hold for a day or so.
Ping @liamjbennett should this be closed? |
@liamjbennett Close this PR? |
I'd actually like to keep get this in. Do we think this requires a major version bump or not? Given that the init.pp at present is only there for example purposes we might be able to get away without it but I would like feedback first |
ensure_resource('windowsfeature', 'Web-ISAPI-Filter' ) | ||
} | ||
default: { | ||
fail("Do not know how to install iis windows features for ${::kernalmajversion}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'kernal' typo
Hmmm. If you're reasonably confident it doesn't change the behaviour with the same params, a major version bump isn't required. I'm a bit wary of the use of |
2916cdd
to
72a79b6
Compare
No description provided.