Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for installing the windows features required for iis #26

Merged
merged 2 commits into from
Feb 12, 2016

Conversation

liamjbennett
Copy link
Member

No description provided.

@@ -0,0 +1,6 @@
class iis::features::application_deployment {
ensure_resource('windowsfeature', 'Web-Asp-Net' )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not quite sure we can do this - there may be different features needed for a 4.0 or a 4.5 account

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I need to do an IIS8 installation and see what's there. I'll put this on hold for a day or so.

@liamjbennett liamjbennett changed the title adding support for installing the windows features required for iis [ON HOLD] adding support for installing the windows features required for iis May 22, 2014
@ffrank
Copy link

ffrank commented Jun 14, 2015

Ping @liamjbennett should this be closed?

@juniorsysadmin
Copy link
Member

@liamjbennett Close this PR?

@liamjbennett
Copy link
Member Author

I'd actually like to keep get this in.

Do we think this requires a major version bump or not? Given that the init.pp at present is only there for example purposes we might be able to get away without it but I would like feedback first

@liamjbennett liamjbennett changed the title [ON HOLD] adding support for installing the windows features required for iis adding support for installing the windows features required for iis Feb 4, 2016
ensure_resource('windowsfeature', 'Web-ISAPI-Filter' )
}
default: {
fail("Do not know how to install iis windows features for ${::kernalmajversion}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'kernal' typo

@juniorsysadmin
Copy link
Member

Do we think this requires a major version bump or not? Given that the init.pp at present is only there for example purposes we might be able to get away without it but I would like feedback first

Hmmm. If you're reasonably confident it doesn't change the behaviour with the same params, a major version bump isn't required. I'm a bit wary of the use of ensure_resource but that's me.

@liamjbennett liamjbennett merged commit 72a79b6 into voxpupuli:master Feb 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants