New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VPC] Use client from ctx in `vpc_2` #1853

Merged

otc-zuul merged 2 commits into devel from vpc-v2-client-ctx

Aug 1, 2022

Contributor

lego963 commented Aug 1, 2022 •

edited

Summary of the Pull Request

Use client from ctx in floatingip_v2, foatingip_associate_v2, vpc_peering_connection_v2, port_v2, vpc_route_v2

PR Checklist

Refers to: [Throttling] Use client from ctx #1848
Tests added/passed.
Schema updated.
Release notes added.

Acceptance Steps Performed

Read comments

Rodion Gyrbu added 2 commits

August 1, 2022 16:27


          Use client from ctx

4a27bfa

Use client from ctx in `floatingip_v2`, `foatingip_associate_v2`, `vpc_peering_connection_v2`, `port_v2`, `vpc_route_v2`


          add reno

29dec14

lego963 requested review from Aloento, anton-sidelnikov, artem-lifshits and vladimirvshivkov

August 1, 2022 13:58

lego963 marked this pull request as ready for review

August 1, 2022 13:58

lego963 mentioned this pull request

[Throttling] Use client from ctx #1848

Closed

32 tasks

artem-lifshits approved these changes

View reviewed changes

Member

artem-lifshits left a comment

=== RUN TestAccVpcRouteV2_basic
=== PAUSE TestAccVpcRouteV2_basic
=== CONT TestAccVpcRouteV2_basic
=== RUN TestAccVpcRouteV2_import
=== PAUSE TestAccVpcRouteV2_import
=== CONT TestAccVpcRouteV2_import
=== RUN TestAccVpcRouteV2_timeout
=== PAUSE TestAccVpcRouteV2_timeout
=== CONT TestAccVpcRouteV2_timeout
--- PASS: TestAccVpcRouteV2_timeout (82.82s)
--- PASS: TestAccVpcRouteV2_basic (85.91s)
--- PASS: TestAccVpcRouteV2_import (97.23s)
PASS

Process finished with the exit code 0

=== RUN TestAccVpcPeeringConnectionV2_basic
=== PAUSE TestAccVpcPeeringConnectionV2_basic
=== CONT TestAccVpcPeeringConnectionV2_basic
=== RUN TestAccVpcPeeringConnectionV2_import
=== PAUSE TestAccVpcPeeringConnectionV2_import
=== CONT TestAccVpcPeeringConnectionV2_import
=== RUN TestAccVpcPeeringConnectionV2_timeout
=== PAUSE TestAccVpcPeeringConnectionV2_timeout
=== CONT TestAccVpcPeeringConnectionV2_timeout
--- PASS: TestAccVpcPeeringConnectionV2_timeout (80.96s)
--- PASS: TestAccVpcPeeringConnectionV2_import (87.58s)
--- PASS: TestAccVpcPeeringConnectionV2_basic (105.65s)
PASS

Process finished with the exit code 0

=== RUN TestAccVpcPeeringConnectionV2_basic
=== PAUSE TestAccVpcPeeringConnectionV2_basic
=== CONT TestAccVpcPeeringConnectionV2_basic
=== RUN TestAccVpcPeeringConnectionV2_import
=== PAUSE TestAccVpcPeeringConnectionV2_import
=== CONT TestAccVpcPeeringConnectionV2_import
=== RUN TestAccVpcPeeringConnectionV2_timeout
=== PAUSE TestAccVpcPeeringConnectionV2_timeout
=== CONT TestAccVpcPeeringConnectionV2_timeout
--- PASS: TestAccVpcPeeringConnectionV2_timeout (80.96s)
--- PASS: TestAccVpcPeeringConnectionV2_import (87.58s)
--- PASS: TestAccVpcPeeringConnectionV2_basic (105.65s)
PASS

Process finished with the exit code 0

=== RUN TestAccNetworkingV2FloatingIP_basic
=== PAUSE TestAccNetworkingV2FloatingIP_basic
=== CONT TestAccNetworkingV2FloatingIP_basic
--- PASS: TestAccNetworkingV2FloatingIP_basic (56.34s)
PASS

=== RUN TestAccNetworkingV2FloatingIP_timeout
=== PAUSE TestAccNetworkingV2FloatingIP_timeout
=== CONT TestAccNetworkingV2FloatingIP_timeout
--- PASS: TestAccNetworkingV2FloatingIP_timeout (54.61s)
PASS

Process finished with the exit code 0

=== RUN TestAccNetworkingV2FloatingIP_importBasic
=== PAUSE TestAccNetworkingV2FloatingIP_importBasic
=== CONT TestAccNetworkingV2FloatingIP_importBasic
--- PASS: TestAccNetworkingV2FloatingIP_importBasic (63.73s)
PASS

Process finished with the exit code 0

=== RUN TestAccNetworkingV2FloatingIPAssociate_basic
=== PAUSE TestAccNetworkingV2FloatingIPAssociate_basic
=== CONT TestAccNetworkingV2FloatingIPAssociate_basic
--- PASS: TestAccNetworkingV2FloatingIPAssociate_basic (94.56s)
PASS

Process finished with the exit code 0

anton-sidelnikov approved these changes

View reviewed changes

lego963 added the gate label

otc-zuul bot commented Aug 1, 2022

Build succeeded.
https://zuul.otc-service.com/t/eco/buildset/a66a98bd80c54641b622555d2d7d7172

✔️ build-otc-releasenotes SUCCESS in 3m 25s
✔️ otc-golangci-lint SUCCESS in 3m 01s
✔️ golang-make-test SUCCESS in 3m 11s
✔️ golang-make-vet SUCCESS in 2m 42s
✔️ tflint SUCCESS in 1m 37s
✔️ goreleaser-build SUCCESS in 7m 57s

otc-zuul bot merged commit 4ddf3f0 into devel

otc-zuul bot deleted the vpc-v2-client-ctx branch

August 1, 2022 14:50

Aloento added a commit that referenced this pull request


          update (#1861)

bec0308

* [ELB] Client from ctx in `resources/lb_v2` (#1852)

[ELB] Client from ctx in `resources/lb_v2`

Summary of the Pull Request
Use client from context in

resource/opentelekomcloud_lb_member_v2
resource/opentelekomcloud_lb_monitor_v2
resource/opentelekomcloud_lb_pool_v2
resource/opentelekomcloud_lb_whitelist_v2
resource/opentelekomcloud_lb_loadbalancer_v2
resource/opentelekomcloud_lb_listener_v2
resource/opentelekomcloud_lb_l7rule_v2
resource/opentelekomcloud_lb_l7policy_v2
resource/opentelekomcloud_lb_certificate_v2

PR Checklist

 Refers to: #1848
 Tests added/passed.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccLBV2Whitelist_basic
=== PAUSE TestAccLBV2Whitelist_basic
=== CONT  TestAccLBV2Whitelist_basic
--- PASS: TestAccLBV2Whitelist_basic (137.18s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2Pool_basic
=== PAUSE TestAccLBV2Pool_basic
=== CONT  TestAccLBV2Pool_basic
--- PASS: TestAccLBV2Pool_basic (168.53s)
=== RUN   TestAccLBV2Pool_persistenceNull
=== PAUSE TestAccLBV2Pool_persistenceNull
=== CONT  TestAccLBV2Pool_persistenceNull
--- PASS: TestAccLBV2Pool_persistenceNull (113.58s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2Monitor_basic
=== PAUSE TestAccLBV2Monitor_basic
=== CONT  TestAccLBV2Monitor_basic
--- PASS: TestAccLBV2Monitor_basic (190.35s)
=== RUN   TestAccLBV2Monitor_minConfig
=== PAUSE TestAccLBV2Monitor_minConfig
=== CONT  TestAccLBV2Monitor_minConfig
--- PASS: TestAccLBV2Monitor_minConfig (190.90s)
PASS

Process finished with the exit code 0

=== RUN   TestAccLBV2Member_basic
=== PAUSE TestAccLBV2Member_basic
=== CONT  TestAccLBV2Member_basic
--- PASS: TestAccLBV2Member_basic (231.74s)
=== RUN   TestAccLBV2Member_import
=== PAUSE TestAccLBV2Member_import
=== CONT  TestAccLBV2Member_import
--- PASS: TestAccLBV2Member_import (154.02s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2LoadBalancer_basic
=== PAUSE TestAccLBV2LoadBalancer_basic
=== CONT  TestAccLBV2LoadBalancer_basic
--- PASS: TestAccLBV2LoadBalancer_basic (112.45s)
=== RUN   TestAccLBV2LoadBalancer_import
=== PAUSE TestAccLBV2LoadBalancer_import
=== CONT  TestAccLBV2LoadBalancer_import
--- PASS: TestAccLBV2LoadBalancer_import (72.07s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2L7Rule_basic
=== PAUSE TestAccLBV2L7Rule_basic
=== CONT  TestAccLBV2L7Rule_basic
--- PASS: TestAccLBV2L7Rule_basic (179.52s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2L7Policy_basic
=== PAUSE TestAccLBV2L7Policy_basic
=== CONT  TestAccLBV2L7Policy_basic
--- PASS: TestAccLBV2L7Policy_basic (118.36s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2Certificate_basic
=== PAUSE TestAccLBV2Certificate_basic
=== CONT  TestAccLBV2Certificate_basic
--- PASS: TestAccLBV2Certificate_basic (135.80s)
=== RUN   TestAccLBV2Certificate_import
=== PAUSE TestAccLBV2Certificate_import
=== CONT  TestAccLBV2Certificate_import
--- PASS: TestAccLBV2Certificate_import (51.91s)
PASS


Process finished with the exit code 0

=== RUN   TestAccLBV2Listener_tls
=== PAUSE TestAccLBV2Listener_tls
=== CONT  TestAccLBV2Listener_tls
--- PASS: TestAccLBV2Listener_tls (144.58s)
PASS


Process finished with the exit code 0

Reviewed-by: Aloento <None>
Reviewed-by: Vladimir Vshivkov <None>

* [VPC] Use client from ctx in `vpc_2` (#1853)

[VPC] Use client from ctx in `vpc_2`

Summary of the Pull Request
Use client from ctx in floatingip_v2, foatingip_associate_v2, vpc_peering_connection_v2, port_v2, vpc_route_v2
PR Checklist

 Refers to: #1848
 Tests added/passed.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
Read comments

Reviewed-by: Artem Lifshits <None>
Reviewed-by: Anton Sidelnikov <None>

* [IAM]: email validation added & resource Update fix (#1856)

[IAM]: email validation added & resource Update fix

Summary of the Pull Request
This PR adds validation for email schema.
PR Checklist

 Refers to:  #1850
 Closes: #1855
 Tests added/passed.
 Schema updated.
 Release notes added.

Acceptance Steps Performed
=== RUN   TestAccIdentityV3User_basic
--- PASS: TestAccIdentityV3User_basic (68.59s)
=== RUN   TestAccIdentityV3User_importBasic
--- PASS: TestAccIdentityV3User_importBasic (64.83s)
PASS

Process finished with the exit code 0

Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com>
Reviewed-by: Aloento <None>
Reviewed-by: Anton Sidelnikov <None>
Reviewed-by: Artem Lifshits <None>

Co-authored-by: Rodion Gyrbu <rodion.gyrbu@t-systems.com>
Co-authored-by: Rodion Gyrbu <rodion.gyrbu@nexign.com>
Co-authored-by: Artem Lifshits <55093318+artem-lifshits@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment