[IAM]: email validation added & resource Update fix #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-lifshits
requested review from
Aloento,
lego963,
vladimirvshivkov and
anton-sidelnikov
lego963
suggested changes
Aug 1, 2022
opentelekomcloud/services/iam/resource_opentelekomcloud_identity_user_v3.go
Show resolved
Hide resolved
opentelekomcloud/services/iam/resource_opentelekomcloud_identity_user_v3.go
Show resolved
Hide resolved
Aloento
previously approved these changes
Aug 1, 2022
|
Tests added: Process finished with the exit code 0 |
anton-sidelnikov
approved these changes
Aug 2, 2022
lego963
approved these changes
Aug 2, 2022
|
Build succeeded. ✔️ build-otc-releasenotes SUCCESS in 3m 21s |
Aloento
added a commit
that referenced
this pull request
Aug 2, 2022
* [ELB] Client from ctx in `resources/lb_v2` (#1852) [ELB] Client from ctx in `resources/lb_v2` Summary of the Pull Request Use client from context in resource/opentelekomcloud_lb_member_v2 resource/opentelekomcloud_lb_monitor_v2 resource/opentelekomcloud_lb_pool_v2 resource/opentelekomcloud_lb_whitelist_v2 resource/opentelekomcloud_lb_loadbalancer_v2 resource/opentelekomcloud_lb_listener_v2 resource/opentelekomcloud_lb_l7rule_v2 resource/opentelekomcloud_lb_l7policy_v2 resource/opentelekomcloud_lb_certificate_v2 PR Checklist Refers to: #1848 Tests added/passed. Release notes added. Acceptance Steps Performed === RUN TestAccLBV2Whitelist_basic === PAUSE TestAccLBV2Whitelist_basic === CONT TestAccLBV2Whitelist_basic --- PASS: TestAccLBV2Whitelist_basic (137.18s) PASS Process finished with the exit code 0 === RUN TestAccLBV2Pool_basic === PAUSE TestAccLBV2Pool_basic === CONT TestAccLBV2Pool_basic --- PASS: TestAccLBV2Pool_basic (168.53s) === RUN TestAccLBV2Pool_persistenceNull === PAUSE TestAccLBV2Pool_persistenceNull === CONT TestAccLBV2Pool_persistenceNull --- PASS: TestAccLBV2Pool_persistenceNull (113.58s) PASS Process finished with the exit code 0 === RUN TestAccLBV2Monitor_basic === PAUSE TestAccLBV2Monitor_basic === CONT TestAccLBV2Monitor_basic --- PASS: TestAccLBV2Monitor_basic (190.35s) === RUN TestAccLBV2Monitor_minConfig === PAUSE TestAccLBV2Monitor_minConfig === CONT TestAccLBV2Monitor_minConfig --- PASS: TestAccLBV2Monitor_minConfig (190.90s) PASS Process finished with the exit code 0 === RUN TestAccLBV2Member_basic === PAUSE TestAccLBV2Member_basic === CONT TestAccLBV2Member_basic --- PASS: TestAccLBV2Member_basic (231.74s) === RUN TestAccLBV2Member_import === PAUSE TestAccLBV2Member_import === CONT TestAccLBV2Member_import --- PASS: TestAccLBV2Member_import (154.02s) PASS Process finished with the exit code 0 === RUN TestAccLBV2LoadBalancer_basic === PAUSE TestAccLBV2LoadBalancer_basic === CONT TestAccLBV2LoadBalancer_basic --- PASS: TestAccLBV2LoadBalancer_basic (112.45s) === RUN TestAccLBV2LoadBalancer_import === PAUSE TestAccLBV2LoadBalancer_import === CONT TestAccLBV2LoadBalancer_import --- PASS: TestAccLBV2LoadBalancer_import (72.07s) PASS Process finished with the exit code 0 === RUN TestAccLBV2L7Rule_basic === PAUSE TestAccLBV2L7Rule_basic === CONT TestAccLBV2L7Rule_basic --- PASS: TestAccLBV2L7Rule_basic (179.52s) PASS Process finished with the exit code 0 === RUN TestAccLBV2L7Policy_basic === PAUSE TestAccLBV2L7Policy_basic === CONT TestAccLBV2L7Policy_basic --- PASS: TestAccLBV2L7Policy_basic (118.36s) PASS Process finished with the exit code 0 === RUN TestAccLBV2Certificate_basic === PAUSE TestAccLBV2Certificate_basic === CONT TestAccLBV2Certificate_basic --- PASS: TestAccLBV2Certificate_basic (135.80s) === RUN TestAccLBV2Certificate_import === PAUSE TestAccLBV2Certificate_import === CONT TestAccLBV2Certificate_import --- PASS: TestAccLBV2Certificate_import (51.91s) PASS Process finished with the exit code 0 === RUN TestAccLBV2Listener_tls === PAUSE TestAccLBV2Listener_tls === CONT TestAccLBV2Listener_tls --- PASS: TestAccLBV2Listener_tls (144.58s) PASS Process finished with the exit code 0 Reviewed-by: Aloento <None> Reviewed-by: Vladimir Vshivkov <None> * [VPC] Use client from ctx in `vpc_2` (#1853) [VPC] Use client from ctx in `vpc_2` Summary of the Pull Request Use client from ctx in floatingip_v2, foatingip_associate_v2, vpc_peering_connection_v2, port_v2, vpc_route_v2 PR Checklist Refers to: #1848 Tests added/passed. Schema updated. Release notes added. Acceptance Steps Performed Read comments Reviewed-by: Artem Lifshits <None> Reviewed-by: Anton Sidelnikov <None> * [IAM]: email validation added & resource Update fix (#1856) [IAM]: email validation added & resource Update fix Summary of the Pull Request This PR adds validation for email schema. PR Checklist Refers to: #1850 Closes: #1855 Tests added/passed. Schema updated. Release notes added. Acceptance Steps Performed === RUN TestAccIdentityV3User_basic --- PASS: TestAccIdentityV3User_basic (68.59s) === RUN TestAccIdentityV3User_importBasic --- PASS: TestAccIdentityV3User_importBasic (64.83s) PASS Process finished with the exit code 0 Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com> Reviewed-by: Aloento <None> Reviewed-by: Anton Sidelnikov <None> Reviewed-by: Artem Lifshits <None> Co-authored-by: Rodion Gyrbu <rodion.gyrbu@t-systems.com> Co-authored-by: Rodion Gyrbu <rodion.gyrbu@nexign.com> Co-authored-by: Artem Lifshits <55093318+artem-lifshits@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds validation for email schema.
PR Checklist
resource_opentelekomcloud_identity_user_v3#1855Acceptance Steps Performed