No payload no marker #1645
Merged
No payload no marker #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1645 +/- ##
==========================================
+ Coverage 66.93% 66.99% +0.05%
==========================================
Files 166 166
Lines 21102 21107 +5
Branches 2588 2590 +2
==========================================
+ Hits 14124 14140 +16
- Misses 6062 6065 +3
+ Partials 916 902 -14
Continue to review full report at Codecov.
|
jwhui
approved these changes
Apr 24, 2017
vaas-krish
pushed a commit
to vaas-krish/openthread
that referenced
this pull request
May 23, 2017
…s/github_2017_04_25 to master * commit 'f25c6727badcddbe7d1d8263478ecb4ec6c40fec': (35 commits) Add `ExitNow()` in MARBLE-387 workaround path. Reduce MTD code size by removing some unused MeshCoP features (openthread#1361) Add/Update logs in `MeshForwarder` class (openthread#1649) Remove use of gnu-extension anonymous struct/union definitions. (openthread#1651) Require platform TRNG to provide requested output length or error. (openthread#1650) Ensure fairness in handling of data polls from sleepy children (openthread#1646) Update formatting in `NcpSpi` and `spi-slave.h` files (openthread#1648) Add EFR32 to readme. (openthread#1647) Add support for SiLabs EFR32. (openthread#1592) No payload no marker (openthread#1645) return the right error information for some cli commands (openthread#1644) Allow to clear Operation Dataset when a new network parameter is set. (openthread#1639) `NcpBuffer`: Fixing bug with handling of longer frame segments (openthread#1643) Fix inherits implicit virtual warning. (openthread#1641) Fix README.md command list of Diag module. (openthread#1640) Fix the error check for src/dst address get in `Frame::ToInfoString()` (openthread#1633) Set Commissioner Data when becoming Leader (openthread#1636) enable all features on posix (openthread#1634) Add `src/core` header files to PRETTY_FILES. (openthread#1632) Remove unnecessary configure options from pretty check. (openthread#1631) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli CoAP client always sets the payload marker, which may cause some CoAP server failed to parse the packet.
Also the current CoAP parser doesn't verify the payload marker. This PR,