Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncp: Add support for fetching MAC counters. #259

Merged
merged 1 commit into from
Jul 12, 2016

Conversation

darconeous
Copy link
Contributor

This change adds several new Spinel counter properties and a new
CAP_COUNTERS capability. These can be used by the host to fetch
the counter values for debugging purposes.

This commit also addresses a few style issues.

This is OpenThread side of the work for issue #199

@darconeous darconeous added this to the 0.01.00 (Initial Official Release) milestone Jul 11, 2016
@darconeous
Copy link
Contributor Author

Please don't merge until I've confirmed that this functionality is behaving correctly with the associated support for wpantund (coming shortly).

This change adds several new Spinel counter properties and a new
`CAP_COUNTERS` capability. These can be used by the host to fetch
the counter values for debugging purposes.

This commit also addresses a few style issues.

This is OpenThread side of the work for issue openthread#199
@darconeous
Copy link
Contributor Author

Ok, I've added support for this to wpantund and confirmed that it appears to be working:

wpanctl:utun6> get
...
NCP:Counter:RX_ERR_BAD_FCS = 0x00
NCP:Counter:RX_ERR_EMPTY = 0x00
NCP:Counter:RX_ERR_NVLD_SADDR = 0x00
NCP:Counter:RX_ERR_OTHER = 0x00
NCP:Counter:RX_ERR_SECURITY = 0x00
NCP:Counter:RX_ERR_UKWN_NBR = 0x00
NCP:Counter:RX_PKT_BEACON = 0x00
NCP:Counter:RX_PKT_BEACON_REQ = 0x00
NCP:Counter:RX_PKT_DATA = 0x00
NCP:Counter:RX_PKT_DATA_POLL = 0x00
NCP:Counter:RX_PKT_FILT_DA = 0x00
NCP:Counter:RX_PKT_FILT_WL = 0x00
NCP:Counter:RX_PKT_OTHER = 0x00
NCP:Counter:RX_PKT_TOTAL = 0x00
NCP:Counter:TX_ERR_CCA = 0x00
NCP:Counter:TX_PKT_ACKED = 0x00
NCP:Counter:TX_PKT_ACK_REQ = 0x00
NCP:Counter:TX_PKT_BEACON = 0x00
NCP:Counter:TX_PKT_BEACON_REQ = 0x10
NCP:Counter:TX_PKT_DATA = 0x07
NCP:Counter:TX_PKT_DATA_POLL = 0x00
NCP:Counter:TX_PKT_NO_ACK_REQ = 0x17
NCP:Counter:TX_PKT_OTHER = 0x00
NCP:Counter:TX_PKT_RETRY = 0x00
NCP:Counter:TX_PKT_TOTAL = 0x17

We can go ahead and merge this when the review is complete and travis passes.

@darconeous
Copy link
Contributor Author

I've already merged support for this into wpantund.

@jwhui
Copy link
Member

jwhui commented Jul 12, 2016

LGTM 👍

@jwhui jwhui merged commit eba3de7 into openthread:master Jul 12, 2016
vaas-krish pushed a commit to vaas-krish/openthread that referenced this pull request May 23, 2017
…ub_a36aea4 to master

* commit '43a39ffa690ec0c7844e99a9a6e43828da71dbf2':
  spi-hdlc-adapter: Various fixes. (openthread#261)
  ncp: Add support for fetching MAC counters. (openthread#259)
  Change link cost for LQI 1 from 6 to 4. (openthread#258)
  ncp: First pass at NCP support for a SPI slave interface. (openthread#254)
  leader should keep its router id recorded (openthread#257)
  cc2538: fix radio driver issue which would impact device acting as SED (openthread#256)
vaas-krish pushed a commit to vaas-krish/openthread that referenced this pull request May 23, 2017
…s/github_2017_04_25 to master

* commit 'f25c6727badcddbe7d1d8263478ecb4ec6c40fec': (35 commits)
  Add `ExitNow()` in MARBLE-387 workaround path.
  Reduce MTD code size by removing some unused MeshCoP features (openthread#1361)
  Add/Update logs in `MeshForwarder` class (openthread#1649)
  Remove use of gnu-extension anonymous struct/union definitions. (openthread#1651)
  Require platform TRNG to provide requested output length or error. (openthread#1650)
  Ensure fairness in handling of data polls from sleepy children (openthread#1646)
  Update formatting in `NcpSpi` and `spi-slave.h` files (openthread#1648)
  Add EFR32 to readme. (openthread#1647)
  Add support for SiLabs EFR32. (openthread#1592)
  No payload no marker (openthread#1645)
  return the right error information for some cli commands (openthread#1644)
  Allow to clear Operation Dataset when a new network parameter is set. (openthread#1639)
  `NcpBuffer`: Fixing bug with handling of longer frame segments (openthread#1643)
  Fix inherits implicit virtual warning. (openthread#1641)
  Fix README.md command list of Diag module. (openthread#1640)
  Fix the error check for src/dst address get in `Frame::ToInfoString()` (openthread#1633)
  Set Commissioner Data when becoming Leader (openthread#1636)
  enable all features on posix (openthread#1634)
  Add `src/core` header files to PRETTY_FILES. (openthread#1632)
  Remove unnecessary configure options from pretty check. (openthread#1631)
  ...
wgtdkp pushed a commit to wgtdkp/openthread that referenced this pull request Dec 22, 2020
lmnotran pushed a commit to SiliconLabs/openthread that referenced this pull request Oct 10, 2023
Merge in WMN_STACKS/openthread from task/openthread/update-openthread-stack to develop/23q4

* commit '7d86c2fdf7e068af0730624cf8c03b059c7f263b': (83 commits)
  [mle] handle received Advertisements from `RxOnlyNeighbor` on FED (openthread#9484)
  [docs] fix typos in Doxygen documentation (openthread#9485)
  [mle] send data polls after Child ID Request ack (openthread#9264)
  [mle] simplify reattach on losing connectivity to leader (openthread#9479)
  [backbone-router] use `TimeTicker` directly to delay registration (openthread#9483)
  [bbr-local] simplify `AddService()` and its use (openthread#9477)
  [github-actions] fix the `codespell` version in `spell-check` job (openthread#9482)
  github-actions: bump actions/checkout from 4.0.0 to 4.1.0 (openthread#9476)
  [routing-manager] new config to use heap for `PrefixTable` entries (openthread#9455)
  [docs] Doxygen tags for CLI commands [`neighbor linkquality` — `networkidtimeout`]  (openthread#9466)
  [nd6] add `RaFlagsExtOption` and track flags in received RAs (openthread#9448)
  [mle] simplify `ProcessRouteTlv()` call in `HandleAdvertisement()` (openthread#9465)
  [joiner] check for non-zero joiner UDP port before electing a joiner router (openthread#9445)
  [posix] address coverity warning: argument cannot be negative (openthread#9453)
  [ip6] update where `HandlePayload()` check `message` is not null (openthread#9462)
  [script] exclude `ot_testing` and `__pycache__` when building the OTBR docker (openthread#9457)
  [docs] adding Doxygen tags for CLIs `mac retries direct` - `mac send` (openthread#9451)
  [docs] add Doxygen tags for CLI commands (`macfilter rss add`  - `macfilter rss remove`) (openthread#9442)
  [address-resolver] set minimum `kMaxNonEvictableSnoopedEntries` to `1` (openthread#9460)
  github-actions: bump github/codeql-action from 2.21.4 to 2.21.8 (openthread#9459)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants