Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mac-filter] change whitelist/blacklist to allowlist/denylist #5507

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

jwhui
Copy link
Member

@jwhui jwhui commented Sep 9, 2020

To promote inclusivity and eliminate any unintentional bias.

@size-report
Copy link

size-report bot commented Sep 9, 2020

Size Report of OpenThread

Merging #5507 into master(11faac0).

name branch text data bss total
ot-cli-ftd_1.1 master 396688 736 72724 470148
#5507 396688 736 72724 470148
+/- 0 0 0 0
ot-cli-mtd_1.1 master 320720 736 64140 385596
#5507 320720 736 64140 385596
+/- 0 0 0 0
ot-ncp-ftd_1.1 master 389664 736 72012 462412
#5507 389664 736 72012 462412
+/- 0 0 0 0
ot-ncp-mtd_1.1 master 317024 736 63428 381188
#5507 317024 736 63428 381188
+/- 0 0 0 0
ot-rcp_1.1 master 63944 636 7512 72092
#5507 63944 636 7512 72092
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 master 39388 0 3100 42488
#5507 39385 0 3100 42485
+/- -3 0 0 -3
libopenthread-cli-mtd.a_1.1 master 31787 0 3100 34887
#5507 31784 0 3100 34884
+/- -3 0 0 -3
libopenthread-ftd.a_1.1 master 194225 4 55020 249249
#5507 194225 4 55020 249249
+/- 0 0 0 0
libopenthread-mtd.a_1.1 master 131747 4 46436 178187
#5507 131747 4 46436 178187
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 master 48018 0 2388 50406
#5507 48016 0 2388 50404
+/- -2 0 0 -2
libopenthread-ncp-mtd.a_1.1 master 43210 0 2388 45598
#5507 43208 0 2388 45596
+/- -2 0 0 -2
libopenthread-rcp.a_1.1 master 27043 0 1532 28575
#5507 27041 0 1532 28573
+/- -2 0 0 -2
libopenthread-radio.a_1.1 master 12366 0 150 12516
#5507 12366 0 150 12516
+/- 0 0 0 0
ot-cli-ftd_1.2 master 417512 736 81412 499660
#5507 417512 736 81412 499660
+/- 0 0 0 0
ot-cli-mtd_1.2 master 329512 736 64332 394580
#5507 329512 736 64332 394580
+/- 0 0 0 0
ot-ncp-ftd_1.2 master 408168 736 80700 489604
#5507 408168 736 80700 489604
+/- 0 0 0 0
ot-ncp-mtd_1.2 master 324904 736 63620 389260
#5507 324904 736 63620 389260
+/- 0 0 0 0
ot-rcp_1.2 master 74620 636 16316 91572
#5507 74620 636 16316 91572
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 master 40798 0 3100 43898
#5507 40795 0 3100 43895
+/- -3 0 0 -3
libopenthread-cli-mtd.a_1.2 master 32271 0 3100 35371
#5507 32268 0 3100 35368
+/- -3 0 0 -3
libopenthread-ftd.a_1.2 master 213450 4 63652 277106
#5507 213450 4 63652 277106
+/- 0 0 0 0
libopenthread-mtd.a_1.2 master 139738 4 46572 186314
#5507 139738 4 46572 186314
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 master 48018 0 2388 50406
#5507 48016 0 2388 50404
+/- -2 0 0 -2
libopenthread-ncp-mtd.a_1.2 master 43210 0 2388 45598
#5507 43208 0 2388 45596
+/- -2 0 0 -2
libopenthread-rcp.a_1.2 master 27043 0 1532 28575
#5507 27041 0 1532 28573
+/- -2 0 0 -2
libopenthread-radio.a_1.2 master 12982 0 150 13132
#5507 12982 0 150 13132
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #5507 into master will decrease coverage by 4.33%.
The diff coverage is 42.42%.

@@            Coverage Diff             @@
##           master    #5507      +/-   ##
==========================================
- Coverage   83.65%   79.31%   -4.34%     
==========================================
  Files         366      366              
  Lines       45695    45153     -542     
==========================================
- Hits        38224    35814    -2410     
- Misses       7471     9339    +1868     
Impacted Files Coverage Δ
src/core/mac/mac_filter.hpp 100.00% <ø> (ø)
src/lib/spinel/spinel.c 76.40% <ø> (-0.33%) ⬇️
src/ncp/ncp_base_dispatcher.cpp 100.00% <ø> (ø)
src/ncp/ncp_base_mtd.cpp 5.38% <0.00%> (-49.20%) ⬇️
src/core/mac/mac_filter.cpp 95.09% <50.00%> (-0.99%) ⬇️
src/cli/cli.cpp 89.98% <100.00%> (ø)
src/ncp/ncp_base.cpp 48.08% <100.00%> (-10.53%) ⬇️
src/core/utils/jam_detector.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/utils/slaac_address.hpp 0.00% <0.00%> (-100.00%) ⬇️
src/core/api/child_supervision_api.cpp 0.00% <0.00%> (-100.00%) ⬇️
... and 124 more

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

To promote inclusivity and eliminate any unintentional bias.
@jwhui jwhui merged commit 5bffd8b into openthread:master Sep 11, 2020
@jwhui jwhui deleted the macfilter branch September 11, 2020 23:03
simonlingoogle pushed a commit to simonlingoogle/openthread that referenced this pull request Nov 12, 2020
Bug: 167332999

* origin/github/master:
  [meshcop] include logging.hpp for helper function 'LogError()' (openthread#5562)
  [cli] fix compile warning (openthread#5552)
  [ot-ctl] auto reconnect session  (openthread#5466)
  [continuous-integration] add code coverage threshold (openthread#5283)
  [thci] support network name with space for wpanctl (openthread#5515)
  [mac] only apply neighbor check when key id mode is 1 (openthread#5550)
  [cli] service and server data as hex-encoded binary values (openthread#5556)
  [cli] implement setting/getting cca threshold (openthread#5532)
  [otns] test with a specific OTNS commit (openthread#5553)
  [posix] fix options dependency (openthread#5548)
  [cli] add api version command (openthread#5544)
  [cli] return error from 'Process{Cmd}()' methods, adding 'OT_ERROR_PENDING' (openthread#5540)
  [cli] implement network data print (openthread#5543)
  [meshcop] add helper function 'LogError()' (openthread#5509)
  [cli] change 'binary' arg to '-x' for consistency (openthread#5543) (openthread#5549)
  [cmake] list targets one per line in unit test CMakeLists (openthread#5541)
  [simulation] fix error handling in simulation flash APIs (openthread#5500)
  [doc] fix broken anchors in CLI Readme (openthread#5542)
  [efr32] update for compatibility with GSDK 3.0 (openthread#5529)
  [coap] make CoAP start and stop reentrant (openthread#5539)
  [platform] remove unused header file (openthread#5538)
  [low-power] fix csl channel (openthread#5501)
  [cmake] make UART RAW config visible in daemon mode (openthread#5535)
  [continuous-integration] fix expect router link (openthread#5534)
  [continuous-integration] use sudo to kill daemon (openthread#5533)
  [thread-cert] add low power case 5_3_01 (openthread#5522)
  [thread-cert] refactor case 9.2.10 using pktverify (openthread#5452)
  [cli] misc enhancements (openthread#5528)
  [low-power] add RCP support for CSL (openthread#5456)
  [gitignore] ignore more files (openthread#5518)
  [github-actions] misc enhancements to otns test (openthread#5519)
  [commissioner] add `State` and `JoinerEvent` enums (c++ style constants) (openthread#5521)
  [mac-filter] change whitelist/blacklist to allowlist/denylist (openthread#5507)
  [coap] update/simplify CoAP Options generation/processing (openthread#5503)
  [joiner] add 'Joiner::State' enumeration (c++ style constants) (openthread#5511)
  [tmf] add Backbone TMF agent (openthread#5471)
  [thread-cert] refactor case 5.6.7 using pktverify (openthread#5453)
  [scripts] fix test_router_reattach (openthread#5517)
  [thci] avoid globbing in scanJoiner (openthread#5513)
  [reference-device] increase CLI RX buffer size (openthread#5514)
  [thread-cert] refactor case 5.6.6 and 5.6.9 using pktverify (openthread#5371)
  [link-quality] optimize RSS calculation (openthread#5508)
  [github-actions] upload test result artifacts (openthread#5479)
  [thread-cert] refactor case 9.2.14 using pktverify (openthread#5429)
  [size-report] add size-report for Thread 1.2 (openthread#5424)
  [nrf528xx] check nrf_802154_sleep_if_idle() return status to set correct pending event (openthread#5504)
  [thread-cert] refactor case 9.2.18 using pktverify (openthread#5444)
  [mle] further simplifications of logging in MLE (openthread#5495)
  [link-quality] fix fuzzer compile failure (openthread#5505)
  [mac-frame] handle exception case for payload of mac cmd (openthread#5499)
  [low-power] remove extra csl tx after buffered message sent by indirect tx (openthread#5497)
  [thread-cert] refactor case 9.2.15 and 9.2.16 using pktverify (openthread#5439)
  [k32w] use a custom Persistent Data Manager (openthread#5496)
  [efr32] fix NVM3 initialization error due to alignment issue (openthread#5491)
  [dua] add NdProxy table on Backbone Router (openthread#5422)
  [thread-cert] fix case 5.5.2 random fail (openthread#5490)
  [mle] declare 'Header' as a private nested type of 'Mle' (openthread#5488)
  [style] remove usage of std::numeric_limits (openthread#5487)
  [low-power] add CSL implementations on nrf52840 (openthread#5449)
  [style] fix include directives (openthread#5485)
  [coap] misc enhancements (openthread#5482)
  [thread-cert] fix case 6.1.9 random fail (openthread#5486)
  [github-actions] fix POSIX workflow coverage uploading (openthread#5472)
  [thread-cert] refactor case 6.1.3, 6.1.5, 6.1.7 and 6.1.9 using pktverify (openthread#5352)
  [thread-cert] refactor case 5.6.1, 5.6.2, 5.6.3, 5.6.4, 5.6.5 using pktverify (openthread#5366)
  [network-data] remove unused/undefined method decelerations (openthread#5480)
  [net] add 'Checksum' class (openthread#5434)
  [thread-cert] refactor case 7.1.2 and 7.1.4 using pktverify (openthread#5369)
  [lgtm] add configuration file (openthread#5473)
  [posix] fix potential buffer overflow in otPlatDiagProcess() (openthread#5478)
  [sub-mac] do not assert when parsing raw-link frames (openthread#5475)
  [cli] fix format string (openthread#5474)
  [low-power] fix csl posix build problem (openthread#5467)
  [mlr] add Commissioner API to register Multicast Listeners (openthread#5346)
  [posix] allow bind to Thread interface only (openthread#4965)
  [mle] simplify logging and add helper log methods (openthread#5470)
  [dns-client] avoid overflow in offset computation (openthread#5464)
  [dhcp6-client] avoid overflow in offset computation (openthread#5463)
  [ip6] skip copying message from 'ProcessReceiveCallback()' (openthread#5469)
  [pktverify] misc enhancement (openthread#5430)
  [mlr] configure MLR.req response status (openthread#5350)
  [thread-cert] refactor case 6.6.1 and 6.6.2 using pktverify (openthread#5368)
  [build] add option to build 1.2 alone (openthread#5364)
Change-Id: I132baf7d7b62230afae5e97f8216ab8962b96ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants