Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change whitelist/blacklist to allowlist/denylist #64

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

tzm41
Copy link
Contributor

@tzm41 tzm41 commented Sep 15, 2020

This PR fixes #63 by updating the naming of MAC filter keywords in accordance with other OpenThread projects.

The PRs openthread/pyspinel#100, openthread/openthread#5507, and openthread/wpantund#474 updated the naming of whitelist/blacklist to allowlist/denylist to promote inclusivity and eliminate any unintentional bias. We update Silk to adapt to the latest wpantund changes.

@tzm41 tzm41 added the enhancement New feature or request label Sep 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   41.72%   41.72%           
=======================================
  Files          37       37           
  Lines        3851     3851           
=======================================
  Hits         1607     1607           
  Misses       2244     2244           
Impacted Files Coverage Δ
silk/config/config.py 0.00% <0.00%> (ø)
silk/node/wpantund_base.py 27.55% <40.00%> (ø)
silk/config/wpan_constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 997c21f...e6133b9. Read the comment docs.

Copy link
Collaborator

@priyankaCh22 priyankaCh22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qilinkang qilinkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit 3f30f88 into openthread:master Sep 16, 2020
@tzm41 tzm41 deleted the macfilter branch September 16, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change whitelist/blacklist to allowlist/denylist
5 participants