[build] fix build with BUILD_SHARED_LIBS=ON #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukepo
force-pushed
the
build/shared-libs
branch
from
5299a83
to
5b05064
Compare
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 76.58% 76.81% +0.22%
==========================================
Files 58 57 -1
Lines 3899 3851 -48
==========================================
- Hits 2986 2958 -28
+ Misses 913 893 -20
Continue to review full report at Codecov.
|
|
@pdgendt could you give it a try? |
gjc13
approved these changes
Jul 15, 2020
pdgendt
approved these changes
Jul 15, 2020
jwhui
approved these changes
Jul 15, 2020
simonlingoogle
pushed a commit
to simonlingoogle/ot-br-posix
that referenced
this pull request
Nov 11, 2020
Issue(s): b/162572906 * origin/github/master: [third_party] update OpenThread (openthread#533) [mdns] fix crash upon avahi access error (openthread#526) [doc] add GitHub Action badges for Build and Docker (openthread#525) [ncp] fix legacy prefix handling (openthread#524) [github-actions] fix repo name in docker workflow (openthread#523) [github-action] add building multi-arch Docker images (openthread#518) [scripts] update to support docker buildx (openthread#518) [build] fix build with BUILD_SHARED_LIBS=ON (openthread#522) Change-Id: I98b2b4bbbd556484eb53d09121f33b5d1a201cd2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.