Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mdns] fix crash upon avahi access error #526

Merged
merged 1 commit into from
Jul 22, 2020
Merged

[mdns] fix crash upon avahi access error #526

merged 1 commit into from
Jul 22, 2020

Conversation

gjc13
Copy link
Member

@gjc13 gjc13 commented Jul 22, 2020

No description provided.

@gjc13 gjc13 requested review from bukepo and jwhui July 22, 2020 09:20
@codecov
Copy link

codecov bot commented Jul 22, 2020 •
edited
Loading

Codecov Report

Merging #526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #526   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          57       57           
  Lines        3849     3850    +1     
=======================================
+ Hits         2958     2959    +1     
  Misses        891      891
Impacted Files Coverage Δ
src/mdns/mdns_avahi.cpp 79.83% <100.00%> (+0.08%) ⬆️
tests/mdns/main.cpp 95.68% <0.00%> (-0.87%) ⬇️
tools/steering_data.cpp 96.87% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7580c...f67bd60. Read the comment docs.

bukepo
bukepo approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@jwhui jwhui added the bug label Jul 22, 2020
@jwhui jwhui merged commit a69a9d5 into openthread:master Jul 22, 2020
turon
turon reviewed Jul 22, 2020
View reviewed changes
Copy link

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixes the issue I had.

simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
[Github Sync] Merge github/master to master
f84b673 
Issue(s): b/162572906

* origin/github/master:
  [third_party] update OpenThread (openthread#533)
  [mdns] fix crash upon avahi access error (openthread#526)
  [doc] add GitHub Action badges for Build and Docker (openthread#525)
  [ncp] fix legacy prefix handling (openthread#524)
  [github-actions] fix repo name in docker workflow (openthread#523)
  [github-action] add building multi-arch Docker images (openthread#518)
  [scripts] update to support docker buildx (openthread#518)
  [build] fix build with BUILD_SHARED_LIBS=ON (openthread#522)
Change-Id: I98b2b4bbbd556484eb53d09121f33b5d1a201cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turon turon turon left review comments

@bukepo bukepo bukepo approved these changes

@jwhui jwhui jwhui approved these changes

Assignees
No one assigned
Labels
bug cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gjc13 @turon @bukepo @jwhui @googlebot