Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] fix legacy prefix handling #524

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Conversation

gjc13
Copy link
Member

@gjc13 gjc13 commented Jul 17, 2020

Correctly intialize/start/stop prefix handling in ncp logic.

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

Correctly intialize/start/stop prefix handling in ncp logic.
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #524 into master will increase coverage by 0.26%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
+ Coverage   76.58%   76.85%   +0.26%     
==========================================
  Files          58       57       -1     
  Lines        3899     3849      -50     
==========================================
- Hits         2986     2958      -28     
+ Misses        913      891      -22     
Impacted Files Coverage Δ
src/agent/ncp_openthread.cpp 75.65% <0.00%> (-1.01%) ⬇️
src/dbus/server/dbus_thread_object.cpp 77.59% <0.00%> (+0.57%) ⬆️
src/common/time.hpp 100.00% <0.00%> (ø)
src/common/code_utils.hpp
src/common/logging.cpp 82.35% <0.00%> (+20.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eefef71...f2c070e. Read the comment docs.

Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhui jwhui merged commit 3e7580c into openthread:master Jul 20, 2020
simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
Issue(s): b/162572906

* origin/github/master:
  [third_party] update OpenThread (openthread#533)
  [mdns] fix crash upon avahi access error (openthread#526)
  [doc] add GitHub Action badges for Build and Docker (openthread#525)
  [ncp] fix legacy prefix handling (openthread#524)
  [github-actions] fix repo name in docker workflow (openthread#523)
  [github-action] add building multi-arch Docker images (openthread#518)
  [scripts] update to support docker buildx (openthread#518)
  [build] fix build with BUILD_SHARED_LIBS=ON (openthread#522)
Change-Id: I98b2b4bbbd556484eb53d09121f33b5d1a201cd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants