Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script] add REFERENCE_DEVICE support #558

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

simonlingoogle
Copy link
Member

@simonlingoogle simonlingoogle commented Sep 14, 2020

This PR builds OTBR for Reference Device.

  • REFERENCE_DEVICE=1 script/setup to build OTBR Reference Device.
  • Add ARG REFERENCE_DEVICE to Dockerfile for building Reference Device.
    • Add --build-arg REFERENCE_DEVICE=1 to Docker build test.

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #558 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #558   +/-   ##
=======================================
  Coverage   78.21%   78.21%           
=======================================
  Files          68       68           
  Lines        4683     4683           
=======================================
  Hits         3663     3663           
  Misses       1020     1020           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80e888...f954e3f. Read the comment docs.

{
with REFERENCE_DEVICE || return 0

sudo apt-get install -y --no-install-recommends radvd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain: Reference Device OTBR always needs radvd.

Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@librasungirl librasungirl changed the title [setup] build for Reference Device [script] add REFERENCE_DEVICE support Sep 21, 2020
@jwhui jwhui merged commit 47ba865 into openthread:master Sep 21, 2020
@simonlingoogle simonlingoogle deleted the reference-device branch September 21, 2020 06:07
simonlingoogle pushed a commit to simonlingoogle/ot-br-posix that referenced this pull request Nov 11, 2020
Bug: 167332999

* origin/github/master:
  [backbone-router] fix OT options for Backone Router (openthread#564)
  [script] add `REFERENCE_DEVICE` support (openthread#558)
  [test] increase the waiting time in dbus tests (openthread#563)
  [flags] configure backbone network interface name (openthread#553)
  [dockerfile] add ARG `OT_BACKBONE_CI` (openthread#556)
  [mac-filter] change whitelist/blacklist to allowlist/denylist (openthread#552)
  [third-party] only add web related modules when necessary (openthread#551)
  [web] topology visualization (openthread#519)
Change-Id: I73c08bf5bc0ebcc9ecb9903a282a2264e6754b0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants